Created Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.
4 years, 9 months ago
(2016-03-12 00:54:38 UTC)
#1
Created Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent,
prepare to multi-client.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777323005/1
4 years, 9 months ago
(2016-03-12 00:55:18 UTC)
#2
4 years, 9 months ago
(2016-03-12 00:56:17 UTC)
#3
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to ...
4 years, 9 months ago
(2016-03-12 00:58:44 UTC)
#4
Message was sent while issue was closed.
Description was changed from
==========
Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client. (patchset #4 id:60001 of
https://codereview.chromium.org/1774323002/ )
Reason for revert:
Introduced leaks. See
https://bugs.chromium.org/p/chromium/issues/detail?id=594304
Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.
>
> For multiclient, we will move the global collection of WorkerInspectorProxy
objects
> to a static collection in WorkerInspectorProxy class.
>
> BUG=590878
>
> Committed: https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f
> Cr-Commit-Position: refs/heads/master@{#380745}
TBR=pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878
==========
to
==========
Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client. (patchset #4 id:60001 of
https://codereview.chromium.org/1774323002/ )
Reason for revert:
Introduced leaks. See
https://bugs.chromium.org/p/chromium/issues/detail?id=594304
Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.
>
> For multiclient, we will move the global collection of WorkerInspectorProxy
objects
> to a static collection in WorkerInspectorProxy class.
>
> BUG=590878
>
> Committed: https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f
> Cr-Commit-Position: refs/heads/master@{#380745}
TBR=pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878
Committed: https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67
Cr-Commit-Position: refs/heads/master@{#380810}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67 Cr-Commit-Position: refs/heads/master@{#380810}
4 years, 9 months ago
(2016-03-12 00:58:45 UTC)
#5
Issue 1777323005: Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.
(Closed)
Created 4 years, 9 months ago by dgozman
Modified 4 years, 9 months ago
Reviewers: pfeldman
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0