Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 1777323005: Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (patchset #4 id:60001 of https://codereview.chromium.org/1774323002/ ) Reason for revert: Introduced leaks. See https://bugs.chromium.org/p/chromium/issues/detail?id=594304 Original issue's description: > [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. > > For multiclient, we will move the global collection of WorkerInspectorProxy objects > to a static collection in WorkerInspectorProxy class. > > BUG=590878 > > Committed: https://crrev.com/6a2dcc610860524680bf95af50ad7367367b705f > Cr-Commit-Position: refs/heads/master@{#380745} TBR=pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590878 Committed: https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67 Cr-Commit-Position: refs/heads/master@{#380810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -153 lines) Patch
M third_party/WebKit/Source/core/frame/FrameConsole.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 3 chunks +42 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 3 chunks +116 lines, -80 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 1 chunk +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 5 chunks +4 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerMessagingProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp View 5 chunks +19 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dgozman
Created Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.
4 years, 9 months ago (2016-03-12 00:54:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777323005/1
4 years, 9 months ago (2016-03-12 00:55:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-12 00:56:17 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 00:58:45 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58925fbb6bf9ab2360a2672424a8ef20b3c0cc67
Cr-Commit-Position: refs/heads/master@{#380810}

Powered by Google App Engine
This is Rietveld 408576698