Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.

Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client. (patchset #3 id:40001 of https://codereview.chromium.org/1774323002/ )

Reason for revert:
Seems to have broken compile on WebKit Linux non-Oilpan Builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oilpan%20Builder/builds/2317

Output snippet:
In file included from ../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31:
In file included from ../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35:
In file included from ../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29:
In file included from ../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35:
In file included from ../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1:
In file included from gen/blink/core/InstrumentingAgentsInl.h:7:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35:
In file included from ../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9:
../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error: static_assert failed "T should be traced"
    static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T should be traced");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in instantiation of member function 'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>, WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::PartitionAllocator> >::trace' requested here
        TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t));
                       ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note: in instantiation of function template specialization 'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>, WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >, WTF::PartitionAllocator> >' requested here
    visitor->trace(m_workersWithEnabledConsole);
             ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note: in instantiation of function template specialization 'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here
DEFINE_TRACE(PageConsoleAgent)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded from macro 'DEFINE_TRACE'
    void T::trace(Visitor* visitor) { traceImpl(visitor); }                    \
                                      ^

Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to multi-client.
>
> For multiclient, we will move the global collection of WorkerInspectorProxy objects
> to a static collection in WorkerInspectorProxy class.
>
> BUG=590878
>
> Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
> Cr-Commit-Position: refs/heads/master@{#380666}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878
Committed: https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d
Cr-Commit-Position: refs/heads/master@{#380668}

[alexmos, 2016-03-11 18:12:16]

Created Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent,
prepare to multi-client.

[commit-bot: I haz the power, 2016-03-11 18:13:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777323004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777323004/1

[commit-bot: I haz the power, 2016-03-11 18:14:10]

Description was changed from

==========
Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client. (patchset #3 id:40001 of
https://codereview.chromium.org/1774323002/ )

Reason for revert:
Seems to have broken compile on WebKit Linux non-Oilpan Builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

Output snippet:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1:
In file included from gen/blink/core/InstrumentingAgentsInl.h:7:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35:
In file included from
../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9:
../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error:
static_assert failed "T should be traced"
    static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T
should be traced");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in
instantiation of member function
'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >::trace' requested here
        TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t));
                       ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note:
in instantiation of function template specialization
'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >' requested here
    visitor->trace(m_workersWithEnabledConsole);
             ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note:
in instantiation of function template specialization
'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here
DEFINE_TRACE(PageConsoleAgent)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded
from macro 'DEFINE_TRACE'
    void T::trace(Visitor* visitor) { traceImpl(visitor); }                    \
                                      ^



Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.
> 
> For multiclient, we will move the global collection of WorkerInspectorProxy
objects
> to a static collection in WorkerInspectorProxy class.
> 
> BUG=590878
> 
> Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
> Cr-Commit-Position: refs/heads/master@{#380666}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878
==========

to

==========
Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client. (patchset #3 id:40001 of
https://codereview.chromium.org/1774323002/ )

Reason for revert:
Seems to have broken compile on WebKit Linux non-Oilpan Builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

Output snippet:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1:
In file included from gen/blink/core/InstrumentingAgentsInl.h:7:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35:
In file included from
../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9:
../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error:
static_assert failed "T should be traced"
    static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T
should be traced");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in
instantiation of member function
'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >::trace' requested here
        TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t));
                       ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note:
in instantiation of function template specialization
'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >' requested here
    visitor->trace(m_workersWithEnabledConsole);
             ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note:
in instantiation of function template specialization
'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here
DEFINE_TRACE(PageConsoleAgent)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded
from macro 'DEFINE_TRACE'
    void T::trace(Visitor* visitor) { traceImpl(visitor); }                    \
                                      ^



Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.
> 
> For multiclient, we will move the global collection of WorkerInspectorProxy
objects
> to a static collection in WorkerInspectorProxy class.
> 
> BUG=590878
> 
> Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
> Cr-Commit-Position: refs/heads/master@{#380666}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878
==========

[commit-bot: I haz the power, 2016-03-11 18:14:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-11 18:15:36]

Description was changed from

==========
Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client. (patchset #3 id:40001 of
https://codereview.chromium.org/1774323002/ )

Reason for revert:
Seems to have broken compile on WebKit Linux non-Oilpan Builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

Output snippet:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1:
In file included from gen/blink/core/InstrumentingAgentsInl.h:7:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35:
In file included from
../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9:
../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error:
static_assert failed "T should be traced"
    static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T
should be traced");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in
instantiation of member function
'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >::trace' requested here
        TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t));
                       ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note:
in instantiation of function template specialization
'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >' requested here
    visitor->trace(m_workersWithEnabledConsole);
             ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note:
in instantiation of function template specialization
'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here
DEFINE_TRACE(PageConsoleAgent)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded
from macro 'DEFINE_TRACE'
    void T::trace(Visitor* visitor) { traceImpl(visitor); }                    \
                                      ^



Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.
> 
> For multiclient, we will move the global collection of WorkerInspectorProxy
objects
> to a static collection in WorkerInspectorProxy class.
> 
> BUG=590878
> 
> Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
> Cr-Commit-Position: refs/heads/master@{#380666}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878
==========

to

==========
Revert of [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client. (patchset #3 id:40001 of
https://codereview.chromium.org/1774323002/ )

Reason for revert:
Seems to have broken compile on WebKit Linux non-Oilpan Builder:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20non-Oi...

Output snippet:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:31:
In file included from
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h:29:
In file included from
../../third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:35:
In file included from
../../third_party/WebKit/Source/core/inspector/InstrumentingAgents.h:1:
In file included from gen/blink/core/InstrumentingAgentsInl.h:7:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:35:
In file included from
../../third_party/WebKit/Source/platform/heap/HeapAllocator.h:9:
../../third_party/WebKit/Source/platform/heap/TraceTraits.h:173:5: error:
static_assert failed "T should be traced"
    static_assert(WTF::NeedsTracing<T>::value || WTF::IsWeak<T>::value, "T
should be traced");
    ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/platform/heap/Visitor.h:193:24: note: in
instantiation of member function
'blink::TraceTrait<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >::trace' requested here
        TraceTrait<T>::trace(Derived::fromHelper(this), &const_cast<T&>(t));
                       ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:67:14: note:
in instantiation of function template specialization
'blink::VisitorHelper<blink::Visitor>::trace<WTF::HashSet<WTF::RawPtr<blink::WorkerInspectorProxy>,
WTF::PtrHash<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::HashTraits<WTF::RawPtr<blink::WorkerInspectorProxy> >,
WTF::PartitionAllocator> >' requested here
    visitor->trace(m_workersWithEnabledConsole);
             ^
../../third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp:63:1: note:
in instantiation of function template specialization
'blink::PageConsoleAgent::traceImpl<blink::Visitor *>' requested here
DEFINE_TRACE(PageConsoleAgent)
^
../../third_party/WebKit/Source/platform/heap/Visitor.h:77:39: note: expanded
from macro 'DEFINE_TRACE'
    void T::trace(Visitor* visitor) { traceImpl(visitor); }                    \
                                      ^

Original issue's description:
> [DevTools] Remove extra plumbing from InspectorWorkerAgent, prepare to
multi-client.
>
> For multiclient, we will move the global collection of WorkerInspectorProxy
objects
> to a static collection in WorkerInspectorProxy class.
>
> BUG=590878
>
> Committed: https://crrev.com/fe63b6b42585c51c7ab9a3b158b20d08d5b552dd
> Cr-Commit-Position: refs/heads/master@{#380666}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=590878

Committed: https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d
Cr-Commit-Position: refs/heads/master@{#380668}
==========

[commit-bot: I haz the power, 2016-03-11 18:15:37]

Patchset 1 (id:??) landed as
https://crrev.com/34f22b83b76ac457f93d35aece3ed56657689d7d
Cr-Commit-Position: refs/heads/master@{#380668}

[dgozman, 2016-03-11 18:28:22]

Don't we have a CQ bot for this? Why patch got committed if it doesn't compile
on some configuration?

[alexmos, 2016-03-11 18:41:18]

On 2016/03/11 18:28:22, dgozman wrote:
> Don't we have a CQ bot for this? Why patch got committed if it doesn't compile
> on some configuration?

+dpranke.  Dirk, do you know why this managed to pass the CQ?

[Dirk Pranke, 2016-03-11 18:50:42]

On 2016/03/11 18:41:18, alexmos wrote:
> On 2016/03/11 18:28:22, dgozman wrote:
> > Don't we have a CQ bot for this? Why patch got committed if it doesn't
compile
> > on some configuration?
> 
> +dpranke.  Dirk, do you know why this managed to pass the CQ?

The non-oilpan waterfall configuration is tested on the CQ by the
"linux_blink_oilpan_rel" (yes, the names are confusing).

Unfortunately, it looks like that's still considered an "experimental" bot, and
so the failures it had on that patch didn't block the CQ.

I'll post a CL today to make it non-experimental, though we're probably going to
remove the non-oilpan config altogether within
a few weeks.