Remove version checks for _MSC_VER < 1800 (msvs2013).

Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.

TBR=reed
No API changes.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1777213003

Committed: https://skia.googlesource.com/skia/+/d7dc76f7e99309cbd09a5420c22e55b951067deb

[bungeman-skia, 2016-03-10 17:13:49]

Description was changed from

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.
==========

to

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-03-10 17:14:08]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 17:14:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777213003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777213003/1

[commit-bot: I haz the power, 2016-03-10 17:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 17:25:47]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-03-10 17:32:02]

Description was changed from

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-03-10 17:33:40]

bungeman@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[bungeman-skia, 2016-03-10 17:33:41]

On my quest to remove all of the code, I have found an old treasure chest.

[mtklein, 2016-03-10 17:37:48]

https://codereview.chromium.org/1777213003/diff/1/src/core/SkBitmapProcState_...
File src/core/SkBitmapProcState_matrixProcs.cpp (left):

https://codereview.chromium.org/1777213003/diff/1/src/core/SkBitmapProcState_...
src/core/SkBitmapProcState_matrixProcs.cpp:176: #if defined(_MSC_VER) &&
(_MSC_VER >= 1600)
This is a >= check... you sure we don't need this any more?
This may have been fixed by SkLeftShift, but we might want to check this
separately from the rest of this CL?

https://codereview.chromium.org/1777213003/diff/1/src/effects/gradients/SkGra...
File src/effects/gradients/SkGradientShaderPriv.h (left):

https://codereview.chromium.org/1777213003/diff/1/src/effects/gradients/SkGra...
src/effects/gradients/SkGradientShaderPriv.h:56: #if defined(_MSC_VER) &&
(_MSC_VER >= 1600)
ditto

https://codereview.chromium.org/1777213003/diff/1/src/effects/gradients/SkLin...
File src/effects/gradients/SkLinearGradient.cpp (left):

https://codereview.chromium.org/1777213003/diff/1/src/effects/gradients/SkLin...
src/effects/gradients/SkLinearGradient.cpp:22: #if defined(_MSC_VER) &&
(_MSC_VER >= 1600)
ditto

[reed1, 2016-03-10 17:42:31]

feel free to TBR me after klein and you reach a consensus

[bungeman-skia, 2016-03-10 17:54:23]

I have the bots running to verify...

https://codereview.chromium.org/1777213003/diff/1/src/core/SkBitmapProcState_...
File src/core/SkBitmapProcState_matrixProcs.cpp (left):

https://codereview.chromium.org/1777213003/diff/1/src/core/SkBitmapProcState_...
src/core/SkBitmapProcState_matrixProcs.cpp:176: #if defined(_MSC_VER) &&
(_MSC_VER >= 1600)
On 2016/03/10 17:37:47, mtklein wrote:
> This is a >= check... you sure we don't need this any more?
> This may have been fixed by SkLeftShift, but we might want to check this
> separately from the rest of this CL?

This was fixed in Visual Studio 2012
(https://connect.microsoft.com/VisualStudio/feedback/details/634455/incorrect-...)

[mtklein, 2016-03-10 18:09:07]

lgtm

[bungeman-skia, 2016-03-10 18:55:02]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-03-10 18:55:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777213003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777213003/1

[commit-bot: I haz the power, 2016-03-10 18:57:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 18:57:01]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bungeman-skia, 2016-03-10 19:13:06]

Description was changed from

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.

TBR=reed
No API changes.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-03-10 19:13:16]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-03-10 19:13:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777213003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777213003/1

[commit-bot: I haz the power, 2016-03-10 19:14:43]

Description was changed from

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.

TBR=reed
No API changes.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove version checks for _MSC_VER < 1800 (msvs2013).

We already actively do not support older versions of the vc++
compiler and runtime, so don't check for them anymore.

TBR=reed
No API changes.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d7dc76f7e99309cbd09a5420c22e55b951067deb
==========

[commit-bot: I haz the power, 2016-03-10 19:14:43]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d7dc76f7e99309cbd09a5420c22e55b951067deb