Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: media/blink/buffered_data_source_unittest.cc

Issue 1777153002: Improve retry support for media network loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed, tests updated Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/buffered_data_source_unittest.cc
diff --git a/media/blink/buffered_data_source_unittest.cc b/media/blink/buffered_data_source_unittest.cc
index eb2114ccb07fa855302c8f854dda8358a7a11c72..10120d25bf5c2b2f0108838345019bec9f16edd7 100644
--- a/media/blink/buffered_data_source_unittest.cc
+++ b/media/blink/buffered_data_source_unittest.cc
@@ -633,18 +633,11 @@ TEST_F(BufferedDataSourceTest, Http_TooManyRetries) {
// Make sure there's a pending read -- we'll expect it to error.
ReadAt(0);
- // It'll try three times.
- ExpectCreateResourceLoader();
- FinishLoading();
- Respond(response_generator_->Generate206(0));
-
- ExpectCreateResourceLoader();
- FinishLoading();
- Respond(response_generator_->Generate206(0));
-
- ExpectCreateResourceLoader();
- FinishLoading();
- Respond(response_generator_->Generate206(0));
+ for (int i = 0; i < 30; i++) {
DaleCurtis 2016/03/11 16:36:32 kLoaderRetries?
hubbe 2016/03/11 18:15:56 Done. (oops)
+ ExpectCreateResourceLoader();
+ FinishLoading();
+ Respond(response_generator_->Generate206(0));
+ }
// It'll error after this.
EXPECT_CALL(*this, ReadCallback(media::DataSource::kReadError));
@@ -660,18 +653,11 @@ TEST_F(BufferedDataSourceTest, File_TooManyRetries) {
// Make sure there's a pending read -- we'll expect it to error.
ReadAt(0);
- // It'll try three times.
- ExpectCreateResourceLoader();
- FinishLoading();
- Respond(response_generator_->GenerateFileResponse(0));
-
- ExpectCreateResourceLoader();
- FinishLoading();
- Respond(response_generator_->GenerateFileResponse(0));
-
- ExpectCreateResourceLoader();
- FinishLoading();
- Respond(response_generator_->GenerateFileResponse(0));
+ for (int i = 0; i < 30; i++) {
DaleCurtis 2016/03/11 16:36:32 Ditto
hubbe 2016/03/11 18:15:56 Done.
+ ExpectCreateResourceLoader();
+ FinishLoading();
+ Respond(response_generator_->GenerateFileResponse(0));
+ }
// It'll error after this.
EXPECT_CALL(*this, ReadCallback(media::DataSource::kReadError));

Powered by Google App Engine
This is Rietveld 408576698