Improve retry support for media network loading.

media/blink/buffered_data_source_unittest.cc

Index: media/blink/buffered_data_source_unittest.cc
diff --git a/media/blink/buffered_data_source_unittest.cc b/media/blink/buffered_data_source_unittest.cc
index eb2114ccb07fa855302c8f854dda8358a7a11c72..10120d25bf5c2b2f0108838345019bec9f16edd7 100644
--- a/media/blink/buffered_data_source_unittest.cc
+++ b/media/blink/buffered_data_source_unittest.cc
@@ -633,18 +633,11 @@ TEST_F(BufferedDataSourceTest, Http_TooManyRetries) {
   // Make sure there's a pending read -- we'll expect it to error.
   ReadAt(0);
 
-  // It'll try three times.
-  ExpectCreateResourceLoader();
-  FinishLoading();
-  Respond(response_generator_->Generate206(0));
-
-  ExpectCreateResourceLoader();
-  FinishLoading();
-  Respond(response_generator_->Generate206(0));
-
-  ExpectCreateResourceLoader();
-  FinishLoading();
-  Respond(response_generator_->Generate206(0));
+  for (int i = 0; i < 30; i++) {

[DaleCurtis, 2016/03/10 01:23:32]

Expose kLoaderRetries on the header file you can use here instead? Or better yet
since these test likely now take 30 seconds, add a SetRetryCountForTesting()
method which limits this to say 3 or 4 retries and ensures the delay grows
between each retry.

[hubbe, 2016/03/11 03:18:53]

Exposed kLoaderRetries.
These tests don't wait for the CB to execute, so they finish very quickly.

+    ExpectCreateResourceLoader();
+    FinishLoading();
+    Respond(response_generator_->Generate206(0));
+  }
 
   // It'll error after this.
   EXPECT_CALL(*this, ReadCallback(media::DataSource::kReadError));
@@ -660,18 +653,11 @@ TEST_F(BufferedDataSourceTest, File_TooManyRetries) {
   // Make sure there's a pending read -- we'll expect it to error.
   ReadAt(0);
 
-  // It'll try three times.
-  ExpectCreateResourceLoader();
-  FinishLoading();
-  Respond(response_generator_->GenerateFileResponse(0));
-
-  ExpectCreateResourceLoader();
-  FinishLoading();
-  Respond(response_generator_->GenerateFileResponse(0));
-
-  ExpectCreateResourceLoader();
-  FinishLoading();
-  Respond(response_generator_->GenerateFileResponse(0));
+  for (int i = 0; i < 30; i++) {

[DaleCurtis, 2016/03/10 01:23:32]

Ditto.

[hubbe, 2016/03/11 03:18:53]

Done.

+    ExpectCreateResourceLoader();
+    FinishLoading();
+    Respond(response_generator_->GenerateFileResponse(0));
+  }
 
   // It'll error after this.
   EXPECT_CALL(*this, ReadCallback(media::DataSource::kReadError));