Improve retry support for media network loading.

media/blink/buffered_data_source.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BLINK_BUFFERED_DATA_SOURCE_H_
 #define MEDIA_BLINK_BUFFERED_DATA_SOURCE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 104 matching lines @@
 };
 
 // A data source capable of loading URLs and buffering the data using an
 // in-memory sliding window.
 //
 // BufferedDataSource must be created and destroyed on the thread associated
 // with the |task_runner| passed in the constructor.
 class MEDIA_BLINK_EXPORT BufferedDataSource
     : NON_EXPORTED_BASE(public BufferedDataSourceInterface) {
  public:
+  // Number of times we retry before erroring out.

[DaleCurtis, 2016/03/11 16:36:32]

Static const on an interface is odd. Enum is preferred these days.  On mobile,
but can send discussion later. You can add the other retry const here too then
and avoid duplicate defs.

[hubbe, 2016/03/11 18:15:55]

This is not an interface, but regardless, enums preferred.
(I remember reading the discussion, after you pointed it out..)

Since intend to delete this class later, I don't want to de-dupe the
two constants.

+  static const int kLoaderRetries;
   typedef base::Callback<void(bool)> DownloadingCB;
 
   // |url| and |cors_mode| are passed to the object. Buffered byte range changes
   // will be reported to |host|. |downloading_cb| will be called whenever the
   // downloading/paused state of the source changes.
   BufferedDataSource(
       const GURL& url,
       BufferedResourceLoader::CORSMode cors_mode,
       const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
       blink::WebFrame* frame,
@@ skipping 191 matching lines @@
   // reaching into this class from multiple threads to attain a WeakPtr.
   base::WeakPtr<BufferedDataSource> weak_ptr_;
   base::WeakPtrFactory<BufferedDataSource> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BufferedDataSource);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BLINK_BUFFERED_DATA_SOURCE_H_