Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: pydir/build-runtime.py

Issue 1777103002: Eliminate all uses of 'le32-nacl-objcopy'. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pydir/crosstest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/build-runtime.py
diff --git a/pydir/build-runtime.py b/pydir/build-runtime.py
index c4ba6d47e63aef0dbff6347d4bc6ba1441cd5826..c4f0b4eb0893c4f1b1015227ff8b1bf9b99d5030 100755
--- a/pydir/build-runtime.py
+++ b/pydir/build-runtime.py
@@ -6,6 +6,7 @@ import shutil
import tempfile
import targets
+from utils import GetObjcopyCmd
Jim Stichnoth 2016/03/09 23:15:24 Maybe put these 3 on a single sorted line like the
Sean Klein 2016/03/09 23:20:20 Done.
from utils import shellcmd
from utils import FindBaseNaCl
@@ -26,7 +27,7 @@ def Translate(ll_files, extra_args, obj, verbose):
'-arm-enable-dwarf-eh=1',
'-o', obj
] + extra_args, echo=verbose)
- shellcmd(['le32-nacl-objcopy',
+ shellcmd([GetObjcopyCmd(),
'--strip-symbol=nacl_tp_tdb_offset',
'--strip-symbol=nacl_tp_tls_offset',
obj
@@ -82,7 +83,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-m {ld_emu}'.format(ld_emu=target_info.ld_emu)],
OutFile('{rtdir}/szrt_native_{target}.o'),
verbose)
- shellcmd(['le32-nacl-objcopy',
+ shellcmd([GetObjcopyCmd(),
'--strip-symbol=NATIVE',
OutFile('{rtdir}/szrt_native_{target}.o')])
@@ -111,7 +112,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-m {ld_emu}'.format(ld_emu=target_info.sb_emu)],
OutFile('{rtdir}/szrt_sb_{target}.o'),
verbose)
- shellcmd(['le32-nacl-objcopy',
+ shellcmd([GetObjcopyCmd(),
'--strip-symbol=NACL',
OutFile('{rtdir}/szrt_sb_{target}.o')])
@@ -139,7 +140,7 @@ def MakeRuntimesForTarget(target_info, ll_files,
['-m {ld_emu}'.format(ld_emu=target_info.ld_emu)],
OutFile('{rtdir}/szrt_nonsfi_{target}.o'),
verbose)
- shellcmd(['le32-nacl-objcopy',
+ shellcmd([GetObjcopyCmd(),
'--strip-symbol=NONSFI',
OutFile('{rtdir}/szrt_nonsfi_{target}.o')])
« no previous file with comments | « no previous file | pydir/crosstest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698