Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: pydir/utils.py

Issue 1777103002: Eliminate all uses of 'le32-nacl-objcopy'. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« pydir/szbuild.py ('K') | « pydir/szbuild.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 import os 1 import os
2 import subprocess 2 import subprocess
3 import sys 3 import sys
4 4
5 def GetObjdumpCmd():
Sean Klein 2016/03/09 22:22:20 This issue is being tracked: https://bugs.chromi
6 """Return a suitable objdump command."""
7 return 'arm-nacl-objdump'
8
9 def GetObjcopyCmd():
10 """Return a suitable objcopy command."""
11 return 'arm-nacl-objcopy'
12
5 def shellcmd(command, echo=True): 13 def shellcmd(command, echo=True):
6 if not isinstance(command, str): 14 if not isinstance(command, str):
7 command = ' '.join(command) 15 command = ' '.join(command)
8 16
9 if echo: 17 if echo:
10 print >> sys.stderr, '[cmd]' 18 print >> sys.stderr, '[cmd]'
11 print >> sys.stderr, command 19 print >> sys.stderr, command
12 print >> sys.stderr 20 print >> sys.stderr
13 21
14 stdout_result = subprocess.check_output(command, shell=True) 22 stdout_result = subprocess.check_output(command, shell=True)
(...skipping 13 matching lines...) Expand all
28 return os.sep.join(path_list[:last_index]) 36 return os.sep.join(path_list[:last_index])
29 37
30 def get_sfi_string(args, sb_ret, nonsfi_ret, native_ret): 38 def get_sfi_string(args, sb_ret, nonsfi_ret, native_ret):
31 """Return a value depending on args.sandbox and args.nonsfi.""" 39 """Return a value depending on args.sandbox and args.nonsfi."""
32 if args.sandbox: 40 if args.sandbox:
33 assert(not args.nonsfi) 41 assert(not args.nonsfi)
34 return sb_ret 42 return sb_ret
35 if args.nonsfi: 43 if args.nonsfi:
36 return nonsfi_ret 44 return nonsfi_ret
37 return native_ret 45 return native_ret
OLDNEW
« pydir/szbuild.py ('K') | « pydir/szbuild.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698