Eliminate all uses of 'le32-nacl-objcopy'.

Eliminate all uses of 'le32-nacl-objcopy'.

Additionally, refactor "GetObjdumpCmd" and "GetObjcopyCmd".

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4361
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1ece70e8289c4728e0f86473656dcdc577293b15

[Sean Klein, 2016-03-09 22:22:19]

smklein@chromium.org changed reviewers:
+ phosek@chromium.org, stichnot@chromium.org

[Sean Klein, 2016-03-09 22:22:20]

Passed presubmit -- PTAL.

https://codereview.chromium.org/1777103002/diff/20001/pydir/utils.py
File pydir/utils.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/utils.py#newcode5
pydir/utils.py:5: def GetObjdumpCmd():
This issue is being tracked: 

https://bugs.chromium.org/p/nativeclient/issues/detail?id=4361

Ideally, these functions will be updated to use the proper "x86" / "arm" /
"mips" versions, but for now, "not broken" seems better than "broken", since
le32-nacl-objcopy is no longer being built by the toolchain build scripts.

[Jim Stichnoth, 2016-03-09 22:41:13]

Thanks!

https://codereview.chromium.org/1777103002/diff/20001/pydir/crosstest.py
File pydir/crosstest.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/crosstest.py#newc...
pydir/crosstest.py:11: from utils import GetObjcopyCmd, shellcmd, FindBaseNaCl,
get_sfi_string
I would say alphabetize these, even though they weren't originally alphabetized.

https://codereview.chromium.org/1777103002/diff/20001/pydir/run-pnacl-sz.py
File pydir/run-pnacl-sz.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/run-pnacl-sz.py#n...
pydir/run-pnacl-sz.py:11: from utils import GetObjdumpCmd, FindBaseNaCl,
shellcmd
alphabetize

https://codereview.chromium.org/1777103002/diff/20001/pydir/szbuild.py
File pydir/szbuild.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/szbuild.py#newcod...
pydir/szbuild.py:296: objcopy = ('{base}/' +
GetObjcopyCmd()).format(base=path_addition)
'{base}/{objcopy}'.format(base=path_addition, objcopy=GetObjcopyCmd())

Same for crosstest.py.

[Sean Klein, 2016-03-09 22:59:23]

https://codereview.chromium.org/1777103002/diff/20001/pydir/crosstest.py
File pydir/crosstest.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/crosstest.py#newc...
pydir/crosstest.py:11: from utils import GetObjcopyCmd, shellcmd, FindBaseNaCl,
get_sfi_string
On 2016/03/09 22:41:13, stichnot wrote:
> I would say alphabetize these, even though they weren't originally
alphabetized.

ASCII alphabetized (uppercase before lowercase).

https://codereview.chromium.org/1777103002/diff/20001/pydir/run-pnacl-sz.py
File pydir/run-pnacl-sz.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/run-pnacl-sz.py#n...
pydir/run-pnacl-sz.py:11: from utils import GetObjdumpCmd, FindBaseNaCl,
shellcmd
On 2016/03/09 22:41:13, stichnot wrote:
> alphabetize

Done.

https://codereview.chromium.org/1777103002/diff/20001/pydir/szbuild.py
File pydir/szbuild.py (right):

https://codereview.chromium.org/1777103002/diff/20001/pydir/szbuild.py#newcod...
pydir/szbuild.py:296: objcopy = ('{base}/' +
GetObjcopyCmd()).format(base=path_addition)
On 2016/03/09 22:41:13, stichnot wrote:
> '{base}/{objcopy}'.format(base=path_addition, objcopy=GetObjcopyCmd())
> 
> Same for crosstest.py.

Done.

[Jim Stichnoth, 2016-03-09 23:15:24]

lgtm

https://codereview.chromium.org/1777103002/diff/40001/pydir/build-runtime.py
File pydir/build-runtime.py (right):

https://codereview.chromium.org/1777103002/diff/40001/pydir/build-runtime.py#...
pydir/build-runtime.py:9: from utils import GetObjcopyCmd
Maybe put these 3 on a single sorted line like the other place?

[Sean Klein, 2016-03-09 23:20:20]

https://codereview.chromium.org/1777103002/diff/40001/pydir/build-runtime.py
File pydir/build-runtime.py (right):

https://codereview.chromium.org/1777103002/diff/40001/pydir/build-runtime.py#...
pydir/build-runtime.py:9: from utils import GetObjcopyCmd
On 2016/03/09 23:15:24, stichnot wrote:
> Maybe put these 3 on a single sorted line like the other place?

Done.

[Sean Klein, 2016-03-09 23:26:43]

Description was changed from

==========
Eliminate all uses of 'le32-nacl-objcopy'.

Additionally, refactor "GetObjdumpCmd" and "GetObjcopyCmd".

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4361
==========

to

==========
Eliminate all uses of 'le32-nacl-objcopy'.

Additionally, refactor "GetObjdumpCmd" and "GetObjcopyCmd".

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4361
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Sean Klein, 2016-03-09 23:26:44]

Committed patchset #4 (id:60001) manually as
1ece70e8289c4728e0f86473656dcdc577293b15 (presubmit successful).