Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1777073002: Revert of [Telemetry] Fix interaction record label warnings (Closed)

Created:
4 years, 9 months ago by eakuefner
Modified:
4 years, 9 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Fix interaction record label warnings (patchset #1 id:1 of https://codereview.chromium.org/1709053002/ ) Reason for revert: Changed smoothness metric names on dashboard because tir_label was not being automatically inserted before. Original issue's description: > [Telemetry] Fix interaction record label warnings > > Fix the smoothness timeline based metric so it doesn't produce these > warnings; and make the warning message itself a bit less spammy. > > BUG=catapult:#2025 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/edb9067dbc83befe6b4fc0dc7560af618e8f2525 TBR=nednguyen@google.com,skyostil@google.com,perezju@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#2025 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e594f4627745a127c43183905a6f4b1bc52f7d2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M telemetry/telemetry/web_perf/metrics/smoothness.py View 2 chunks +4 lines, -6 lines 0 comments Download
M telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
eakuefner
Created Revert of [Telemetry] Fix interaction record label warnings
4 years, 9 months ago (2016-03-09 21:00:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777073002/1
4 years, 9 months ago (2016-03-09 21:00:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777073002/1
4 years, 9 months ago (2016-03-09 21:01:56 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:13:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698