Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1777063002: Switch android builders on tryserver.chromium.perf from gyp to gn (Closed)

Created:
4 years, 9 months ago by prasadv
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch android builders on tryserver.chromium.perf from gyp to gn Also deleted 'gyp_official_goma_minimal_symbols_android' and 'gyp_official_goma_minimal_symbols_android_arm64' from the config as presubmit complained about unused configs. BUG=593439 Committed: https://crrev.com/ad879442a66b0b7d1500dd8df0a2d027602c358a Cr-Commit-Position: refs/heads/master@{#381049}

Patch Set 1 #

Patch Set 2 : Adding N5x and Webview bisect bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M tools/mb/mb_config.pyl View 1 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
prasadv
4 years, 9 months ago (2016-03-09 20:35:18 UTC) #2
jbudorick
While I don't see any issues with the changes themselves, these bots aren't running mb ...
4 years, 9 months ago (2016-03-09 20:40:05 UTC) #4
Dirk Pranke
lgtm for whenever you're ready for this.
4 years, 9 months ago (2016-03-09 22:59:33 UTC) #5
prasadv
John@, Now that the recipe changes are in, is it OK to land this change? ...
4 years, 9 months ago (2016-03-10 22:13:31 UTC) #6
jbudorick
lgtm
4 years, 9 months ago (2016-03-10 22:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777063002/20001
4 years, 9 months ago (2016-03-14 18:24:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 19:55:39 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 19:56:44 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad879442a66b0b7d1500dd8df0a2d027602c358a
Cr-Commit-Position: refs/heads/master@{#381049}

Powered by Google App Engine
This is Rietveld 408576698