Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 177703006: dbus: Handle NameOwnerChanged in ObjectManager (Closed)

Created:
6 years, 9 months ago by keybuk
Modified:
6 years, 9 months ago
Reviewers:
zeuthen, satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

dbus: Handle NameOwnerChanged in ObjectManager Since the ObjectManager class managers the set of object proxies and properties structures for remote service it needs to handle the NameOwnerChanged signal, deleting the current set of objects when a previously owned name changes to a new owner (or is released) and re-requesting the set of managed objects when a name is claimed by a new owner. BUG=346975 TEST=dbus_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M dbus/object_manager.h View 1 chunk +6 lines, -0 lines 0 comments Download
M dbus/object_manager.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M dbus/object_manager_unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M dbus/test_service.h View 2 chunks +23 lines, -0 lines 0 comments Download
M dbus/test_service.cc View 2 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
keybuk
6 years, 9 months ago (2014-03-05 23:40:21 UTC) #1
satorux1
LGTM
6 years, 9 months ago (2014-03-06 04:49:25 UTC) #2
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-06 18:17:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/177703006/1
6 years, 9 months ago (2014-03-06 18:21:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:07:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests, telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=233292
6 years, 9 months ago (2014-03-06 19:07:59 UTC) #6
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-06 19:13:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/177703006/1
6 years, 9 months ago (2014-03-06 19:20:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/177703006/1
6 years, 9 months ago (2014-03-06 21:01:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/177703006/1
6 years, 9 months ago (2014-03-06 21:55:20 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 02:24:35 UTC) #11
Message was sent while issue was closed.
Change committed as 255495

Powered by Google App Engine
This is Rietveld 408576698