Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1777013004: Small cleanup refactoring of sp-to-fp offset and slot conversions (Closed)

Created:
4 years, 9 months ago by danno
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Small cleanup refactoring of sp-to-fp offset and slot conversions Committed: https://crrev.com/33bc6282b017a68351d5ef040ee7da226eab711a Cr-Commit-Position: refs/heads/master@{#34709}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/frame.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/frame.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danno
PTAL
4 years, 9 months ago (2016-03-10 17:11:19 UTC) #2
Jarin
lgtm https://codereview.chromium.org/1777013004/diff/1/src/compiler/frame.cc File src/compiler/frame.cc (right): https://codereview.chromium.org/1777013004/diff/1/src/compiler/frame.cc#newcode53 src/compiler/frame.cc:53: int sp_offset = frame_offset + GetSpToFpOffset(); Tiny nit: ...
4 years, 9 months ago (2016-03-11 06:19:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777013004/20001
4 years, 9 months ago (2016-03-11 09:09:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 09:32:20 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 09:32:31 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33bc6282b017a68351d5ef040ee7da226eab711a
Cr-Commit-Position: refs/heads/master@{#34709}

Powered by Google App Engine
This is Rietveld 408576698