Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1777013002: Fix nullptr access in GrTextureProvider::createMipMappedTexture (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nullptr access in GrTextureProvider::createMipMappedTexture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/GrTextureProvider.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bsalomon
4 years, 9 months ago (2016-03-09 15:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777013002/1
4 years, 9 months ago (2016-03-09 15:44:45 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-09 15:44:46 UTC) #6
robertphillips
https://codereview.chromium.org/1777013002/diff/1/src/gpu/GrTextureProvider.cpp File src/gpu/GrTextureProvider.cpp (right): https://codereview.chromium.org/1777013002/diff/1/src/gpu/GrTextureProvider.cpp#newcode57 src/gpu/GrTextureProvider.cpp:57: size_t baseRowBytes = 0; > 0 ?
4 years, 9 months ago (2016-03-09 15:46:20 UTC) #8
bsalomon
On 2016/03/09 15:46:20, robertphillips wrote: > https://codereview.chromium.org/1777013002/diff/1/src/gpu/GrTextureProvider.cpp > File src/gpu/GrTextureProvider.cpp (right): > > https://codereview.chromium.org/1777013002/diff/1/src/gpu/GrTextureProvider.cpp#newcode57 > ...
4 years, 9 months ago (2016-03-09 15:50:08 UTC) #9
robertphillips
lgtm
4 years, 9 months ago (2016-03-09 15:55:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777013002/20001
4 years, 9 months ago (2016-03-09 15:58:06 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 17:52:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7467ab8cc0818008649f043fb98127c929c2eb37

Powered by Google App Engine
This is Rietveld 408576698