Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1776993007: Rename Init.h to CoreInitializer.h, and InitModules.h to ModuleInitializer.h (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Init.h to CoreInitializer.h, and InitModules.h to ModuleInitializer.h A file name should match with the class names in the file. BUG=593269 Committed: https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3 Cr-Commit-Position: refs/heads/master@{#382193}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -343 lines) Patch
M third_party/WebKit/Source/bindings/templates/partial_interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/CoreInitializer.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/CoreInitializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/Init.h View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/core/Init.cpp View 1 chunk +0 lines, -165 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/InitModules.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/modules/InitModules.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
A + third_party/WebKit/Source/modules/ModulesInitializer.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/modules/ModulesInitializer.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 1 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-11 14:35:51 UTC) #2
sof
lgtm needs a rebase once https://codereview.chromium.org/1787643003/ lands, i reckon.
4 years, 9 months ago (2016-03-11 14:43:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776993007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776993007/20001
4 years, 9 months ago (2016-03-19 09:07:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-19 10:10:26 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 10:11:46 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e67be9ca3492420dff5c960cd10789d5f0597ae3
Cr-Commit-Position: refs/heads/master@{#382193}

Powered by Google App Engine
This is Rietveld 408576698