pass cap to dash text

pass cap to dash text

Pass the paint cap parameter through to text rendering so
that dashed text draws correctly.

R=bungeman@google.com
BUG=226341
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776983002

Committed: https://skia.googlesource.com/skia/+/d7ea92f2ff8ba41783296ff8e6203a59a5549c1a

[caryclark, 2016-03-09 13:34:27]

Description was changed from

==========
pass cap to dash text

Pass the paint cap parameter through to text rendering so
that dashed text draws correctly.

R=bungeman@google.com
BUG=226341
==========

to

==========
pass cap to dash text

Pass the paint cap parameter through to text rendering so
that dashed text draws correctly.

R=bungeman@google.com
BUG=226341
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-03-09 13:35:43]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 13:35:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776983002/1

[commit-bot: I haz the power, 2016-03-09 13:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 13:48:20]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-03-09 15:32:57]

lgtm with some totally optional observations.

https://codereview.chromium.org/1776983002/diff/1/src/core/SkScalerContext.h
File src/core/SkScalerContext.h (right):

https://codereview.chromium.org/1776983002/diff/1/src/core/SkScalerContext.h#...
src/core/SkScalerContext.h:83: uint8_t     fStrokeCap : 4;
This is a cool way to get these bits in, though it would be nice to point out
that these are actually 2 bits each  (there are only three values for each).
This would make things clearer to future bit miners. On the other hand, having

uint8_t fStronkeJoin : 2;
uint8_t fStrokeCap : 2;
uint8_t fExtraBitsThatNeedToBe0 : 4

(and needing to set the 0 bits to 0 in MakeRec) is rather ugly.

It would also be nice to assert that this is enough space (kCapCount and
kJoinCount) though I admit that the possibility of adding to those enums seems
remote.

[caryclark, 2016-03-09 16:45:32]

> It would also be nice to assert that this is enough space (kCapCount and
> kJoinCount) though I admit that the possibility of adding to those enums seems
> remote.

I couldn't come up with a static assert to ensure that kCapCount - 1 is
representable in the bitfield. Any suggestions?

[caryclark, 2016-03-16 14:18:39]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-03-16 14:18:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776983002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776983002/1

[commit-bot: I haz the power, 2016-03-16 14:34:07]

Description was changed from

==========
pass cap to dash text

Pass the paint cap parameter through to text rendering so
that dashed text draws correctly.

R=bungeman@google.com
BUG=226341
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
pass cap to dash text

Pass the paint cap parameter through to text rendering so
that dashed text draws correctly.

R=bungeman@google.com
BUG=226341
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d7ea92f2ff8ba41783296ff8e6203a59a5549c1a
==========

[commit-bot: I haz the power, 2016-03-16 14:34:08]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d7ea92f2ff8ba41783296ff8e6203a59a5549c1a