Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1776973004: MD Settings: add dpapad@ to some OWNERS files (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add dpapad@ to some OWNERS files R=dpapad@chromium.org BUG=none TEST=more reviews! NOTRY=true Committed: https://crrev.com/b739f0dbcca48a29c264a55ad0f61ae202297db2 Cr-Commit-Position: refs/heads/master@{#380449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/app/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Dan Beam
4 years, 9 months ago (2016-03-10 04:55:16 UTC) #1
dpapad
lgtm
4 years, 9 months ago (2016-03-10 18:01:50 UTC) #3
Dan Beam
+grt@ for OWNERS stamp (I'm adding 1 new OWNER to settings* specific stuff in chrome/apps/)
4 years, 9 months ago (2016-03-10 18:25:49 UTC) #7
grt (UTC plus 2)
chrome/app lgtm
4 years, 9 months ago (2016-03-10 19:16:59 UTC) #9
dschuyler
lgtm
4 years, 9 months ago (2016-03-10 19:28:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776973004/1
4 years, 9 months ago (2016-03-10 19:41:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 19:54:52 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:57:43 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b739f0dbcca48a29c264a55ad0f61ae202297db2
Cr-Commit-Position: refs/heads/master@{#380449}

Powered by Google App Engine
This is Rietveld 408576698