Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: base/metrics/metrics_hashes.cc

Issue 1776973002: Revert of Collect information about failing histogram factory calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/histogram_unittest.cc ('k') | base/metrics/statistics_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/metrics_hashes.cc
diff --git a/base/metrics/metrics_hashes.cc b/base/metrics/metrics_hashes.cc
index 54c117bef754636b81e166179350a850f758bb7e..5672b06decb2ef2aa51efb5b705692ceaaf4794e 100644
--- a/base/metrics/metrics_hashes.cc
+++ b/base/metrics/metrics_hashes.cc
@@ -4,7 +4,6 @@
#include "base/metrics/metrics_hashes.h"
-#include "base/debug/alias.h"
#include "base/logging.h"
#include "base/md5.h"
#include "base/sys_byteorder.h"
@@ -16,14 +15,9 @@
// Converts the 8-byte prefix of an MD5 hash into a uint64_t value.
inline uint64_t DigestToUInt64(const base::MD5Digest& digest) {
uint64_t value;
- CHECK_GE(sizeof(digest.a), sizeof(value));
+ DCHECK_GE(sizeof(digest.a), sizeof(value));
memcpy(&value, digest.a, sizeof(value));
- uint64_t hash = base::NetToHost64(value);
- CHECK_NE(0U, hash);
- base::debug::Alias(&hash);
- base::debug::Alias(&value);
- base::debug::Alias(&digest);
- return hash;
+ return base::NetToHost64(value);
}
} // namespace
« no previous file with comments | « base/metrics/histogram_unittest.cc ('k') | base/metrics/statistics_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698