Chromium Code Reviews
DescriptionRevert of Use Display.getRealMetrics() to calculate device size (patchset #6 id:100001 of https://codereview.chromium.org/1770883004/ )
Reason for revert:
Speculative revert for https://bugs.chromium.org/p/chromium/issues/detail?id=593322
BUG=593322
Original issue's description:
> Use Display.getRealMetrics() to calculate device size
>
> Regular DisplayMetrics subtract the window decorations, causing
> the DeviceFormFactor.isTablet() calculation to be incorrect.
> To account for multi-window on N, use Display.getRealMetrics() instead.
> This API method is only available in level 17+, so use
> Configuration.smallestScreenWidthDp as a fallback.
>
> BUG=591861
>
> Committed: https://crrev.com/c6d363b1b16ef1de57ad555ea3efabb61fe38801
> Cr-Commit-Position: refs/heads/master@{#379955}
TBR=newt@chromium.org,twellington@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=591861
Committed: https://crrev.com/170e6a54eeb57a17a6909e88770d2cab88b7901c
Cr-Commit-Position: refs/heads/master@{#380127}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
||||||||||||||||||||||||||||