Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1776963002: Revert of Use Display.getRealMetrics() to calculate device size (Closed)

Created:
4 years, 9 months ago by Benoit L
Modified:
4 years, 9 months ago
Reviewers:
Theresa, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Display.getRealMetrics() to calculate device size (patchset #6 id:100001 of https://codereview.chromium.org/1770883004/ ) Reason for revert: Speculative revert for https://bugs.chromium.org/p/chromium/issues/detail?id=593322 BUG=593322 Original issue's description: > Use Display.getRealMetrics() to calculate device size > > Regular DisplayMetrics subtract the window decorations, causing > the DeviceFormFactor.isTablet() calculation to be incorrect. > To account for multi-window on N, use Display.getRealMetrics() instead. > This API method is only available in level 17+, so use > Configuration.smallestScreenWidthDp as a fallback. > > BUG=591861 > > Committed: https://crrev.com/c6d363b1b16ef1de57ad555ea3efabb61fe38801 > Cr-Commit-Position: refs/heads/master@{#379955} TBR=newt@chromium.org,twellington@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591861 Committed: https://crrev.com/170e6a54eeb57a17a6909e88770d2cab88b7901c Cr-Commit-Position: refs/heads/master@{#380127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 3 chunks +6 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/base/DeviceFormFactor.java View 2 chunks +18 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benoit L
Created Revert of Use Display.getRealMetrics() to calculate device size
4 years, 9 months ago (2016-03-09 13:16:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776963002/1
4 years, 9 months ago (2016-03-09 13:16:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 13:16:40 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 13:17:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/170e6a54eeb57a17a6909e88770d2cab88b7901c
Cr-Commit-Position: refs/heads/master@{#380127}

Powered by Google App Engine
This is Rietveld 408576698