Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1776953002: [regexp] allow loose matching for property names. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] allow loose matching for property names. As described in unicode database file PropertyValueAliases.txt R=littledan@chromium.org BUG=v8:4743 LOG=N Committed: https://crrev.com/48f9c161840a5c47c72098f66f03cf763736f62b Cr-Commit-Position: refs/heads/master@{#34638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/char-predicates.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/char-predicates-inl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-general-category.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
4 years, 9 months ago (2016-03-09 13:14:36 UTC) #1
Dan Ehrenberg
lgtm So this patch is not really about aliases in general (since some were allowed) ...
4 years, 9 months ago (2016-03-09 16:55:44 UTC) #2
Yang
On 2016/03/09 16:55:44, Dan Ehrenberg wrote: > lgtm > > So this patch is not ...
4 years, 9 months ago (2016-03-09 18:41:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776953002/1
4 years, 9 months ago (2016-03-09 18:42:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 19:05:08 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 19:07:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48f9c161840a5c47c72098f66f03cf763736f62b
Cr-Commit-Position: refs/heads/master@{#34638}

Powered by Google App Engine
This is Rietveld 408576698