Register ArrayBufferContents' adjustAmountOfMemory in V8Initializer::initialize

Register ArrayBufferContents' adjustAmountOfMemory in V8Initializer::initialize

Currently ArrayBufferContents' adjustAmountOfMemory is registered in initializeWithoutV8
but this is not nice because adjustAmountOfMemory is a method used *with* V8.
The registration should be moved to V8Initializer::initialize.

BUG=593269
Committed: https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217
Cr-Commit-Position: refs/heads/master@{#380450}

[haraken, 2016-03-09 12:29:06]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-03-09 12:29:07]

PTAL

[sof, 2016-03-09 13:08:39]

https://codereview.chromium.org/1776943002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/1776943002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:363:
WTF::ArrayBufferContents::setAdjustAmoutOfExternalAllocatedMemoryFunction(adjustAmountOfExternalAllocatedMemory);
Not introduced here, but s/Amout/Amount/

https://codereview.chromium.org/1776943002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:363:
WTF::ArrayBufferContents::setAdjustAmoutOfExternalAllocatedMemoryFunction(adjustAmountOfExternalAllocatedMemory);
Not a big deal, but worth bringing up -- would it be tidier to have
WTF::ArrayBufferContents::initializeForMainThread() which hid this registration
detail?

[haraken, 2016-03-10 00:04:35]

https://codereview.chromium.org/1776943002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/1776943002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:363:
WTF::ArrayBufferContents::setAdjustAmoutOfExternalAllocatedMemoryFunction(adjustAmountOfExternalAllocatedMemory);
On 2016/03/09 13:08:38, sof wrote:
> Not introduced here, but s/Amout/Amount/

Done.

https://codereview.chromium.org/1776943002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:363:
WTF::ArrayBufferContents::setAdjustAmoutOfExternalAllocatedMemoryFunction(adjustAmountOfExternalAllocatedMemory);
On 2016/03/09 13:08:38, sof wrote:
> Not a big deal, but worth bringing up -- would it be tidier to have
> WTF::ArrayBufferContents::initializeForMainThread() which hid this
registration
> detail?

Done.

[haraken, 2016-03-10 11:20:24]

Tests pass :)

[sof, 2016-03-10 11:49:02]

lgtm

[haraken, 2016-03-10 11:56:14]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-03-10 11:56:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776943002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776943002/40001

[commit-bot: I haz the power, 2016-03-10 12:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 12:04:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-03-10 13:56:09]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-03-10 13:56:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1776943002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-10 13:56:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776943002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776943002/60001

[commit-bot: I haz the power, 2016-03-10 16:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 16:32:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sof, 2016-03-10 16:34:09]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-03-10 16:34:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776943002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776943002/60001

[commit-bot: I haz the power, 2016-03-10 19:55:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-10 19:57:44]

Description was changed from

==========
Register ArrayBufferContents' adjustAmountOfMemory in V8Initializer::initialize

Currently ArrayBufferContents' adjustAmountOfMemory is registered in
initializeWithoutV8
but this is not nice because adjustAmountOfMemory is a method used *with* V8.
The registration should be moved to V8Initializer::initialize.

BUG=593269
==========

to

==========
Register ArrayBufferContents' adjustAmountOfMemory in V8Initializer::initialize

Currently ArrayBufferContents' adjustAmountOfMemory is registered in
initializeWithoutV8
but this is not nice because adjustAmountOfMemory is a method used *with* V8.
The registration should be moved to V8Initializer::initialize.

BUG=593269

Committed: https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217
Cr-Commit-Position: refs/heads/master@{#380450}
==========

[commit-bot: I haz the power, 2016-03-10 19:57:45]

Patchset 4 (id:??) landed as
https://crrev.com/02cfffa779037fd8db51b7cb8146753df51ed217
Cr-Commit-Position: refs/heads/master@{#380450}