Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1776933003: [arm] Basic simulation of msr and mrs. (Closed)

Created:
4 years, 9 months ago by jbramley
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Basic simulation of msr and mrs. Only CPSR_f is supported, and then only for the flags that we actually simulate (NZCV). This isn't currently used, but will be useful for some tests. BUG= Committed: https://crrev.com/6b6236587d87cb7247caa52935bd27a3cd069501 Cr-Commit-Position: refs/heads/master@{#34662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -4 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +27 lines, -1 line 0 comments Download
M src/arm/simulator-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +42 lines, -1 line 0 comments Download
M test/cctest/test-assembler-arm.cc View 2 chunks +73 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 9 months ago (2016-03-09 11:28:05 UTC) #2
Jarin
lgtm (mostly rubber-stamp)
4 years, 9 months ago (2016-03-09 16:36:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776933003/1
4 years, 9 months ago (2016-03-10 11:19:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 11:38:22 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 11:39:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b6236587d87cb7247caa52935bd27a3cd069501
Cr-Commit-Position: refs/heads/master@{#34662}

Powered by Google App Engine
This is Rietveld 408576698