Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1776923005: [Wasm] Move data segment data inline to the data segment section (Closed)

Created:
4 years, 9 months ago by binji
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Wasm] Move data segment data inline to the data segment section BUG= R=titzer@chromium.org Committed: https://crrev.com/29cd25be1daa790afff5a7d6f7551604bbe51af3 Cr-Commit-Position: refs/heads/master@{#34639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -133 lines) Patch
M src/wasm/encoder.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M src/wasm/module-decoder.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 4 chunks +5 lines, -49 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 9 chunks +29 lines, -70 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
4 years, 9 months ago (2016-03-09 18:56:21 UTC) #1
titzer
lgtm, nice!
4 years, 9 months ago (2016-03-09 18:57:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776923005/1
4 years, 9 months ago (2016-03-09 19:27:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 19:43:08 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 19:43:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/29cd25be1daa790afff5a7d6f7551604bbe51af3
Cr-Commit-Position: refs/heads/master@{#34639}

Powered by Google App Engine
This is Rietveld 408576698