core/src/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp - Issue 1776913007: Split fpdf_parser_objects.cpp into per-class .cpp/.h files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

Issue 1776913007: Split fpdf_parser_objects.cpp into per-class .cpp/.h files. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« core/src/fpdfapi/fpdf_parser/cpdf_object.cpp ('K') | « core/src/fpdfapi/fpdf_parser/cpdf_object.cpp ('k') | core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp » ('j') | core/src/fpdfapi/fpdf_parser/cpdf_stream.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: core/src/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp b/core/src/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

similarity index 98%

rename from core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp

rename to core/src/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

index a377a92e44acba6eaec2017ab94ae1b66542ce87..87ef34fd6ac81144a533896fb1242c3c295600ad 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp

+++ b/core/src/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

@@ -2,12 +2,21 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "core/include/fpdfapi/fpdf_objects.h"

+#include "core/include/fpdfapi/cpdf_array.h"

+#include "core/include/fpdfapi/cpdf_boolean.h"

+#include "core/include/fpdfapi/cpdf_dictionary.h"

+#include "core/include/fpdfapi/cpdf_name.h"

+#include "core/include/fpdfapi/cpdf_null.h"

+#include "core/include/fpdfapi/cpdf_number.h"

+#include "core/include/fpdfapi/cpdf_reference.h"

+#include "core/include/fpdfapi/cpdf_string.h"

+#include "core/include/fpdfapi/cpdf_stream.h"

dsinclair 2016/03/10 21:23:45 Can this test be split to per object type? Or, fil

Tom Sepez 2016/03/10 22:05:19 we'll split it later, that was my intent.

#include <memory>

#include <string>

#include <vector>

+#include "core/include/fpdfapi/cpdf_indirect_object_holder.h"

#include "core/include/fxcrt/fx_basic.h"

#include "testing/gtest/include/gtest/gtest.h"