Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1776913005: Simplify the interface of PropertyCallbackArguments (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify the interface of PropertyCallbackArguments Use internal handles as API, and move boilerplate code into the call wrappers. BUG= Committed: https://crrev.com/3f027300dc25b38d2c99cf35d590b09e2111ca61 Cr-Commit-Position: refs/heads/master@{#34684}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -217 lines) Patch
M src/api-arguments.h View 1 2 3 4 5 6 4 chunks +96 lines, -43 lines 1 comment Download
M src/api-arguments.cc View 1 2 3 4 5 1 chunk +11 lines, -65 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 3 chunks +6 lines, -15 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 3 chunks +8 lines, -20 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 15 chunks +32 lines, -74 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-10 13:50:36 UTC) #3
Jakob Kummerow
LGTM https://codereview.chromium.org/1776913005/diff/120001/src/api-arguments.h File src/api-arguments.h (right): https://codereview.chromium.org/1776913005/diff/120001/src/api-arguments.h#newcode118 src/api-arguments.h:118: Isolate* isolate = this->isolate(); \ Does it matter ...
4 years, 9 months ago (2016-03-10 15:04:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776913005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776913005/120001
4 years, 9 months ago (2016-03-10 15:25:50 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-10 15:45:36 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 15:46:27 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3f027300dc25b38d2c99cf35d590b09e2111ca61
Cr-Commit-Position: refs/heads/master@{#34684}

Powered by Google App Engine
This is Rietveld 408576698