Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1776913003: Add SkImage::NewTextureFromPixmap (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
reed, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : add correct function to the no-gpu build #

Patch Set 3 : add comment #

Patch Set 4 : include initializer_list #

Patch Set 5 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -51 lines) Patch
M include/core/SkImage.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 4 chunks +49 lines, -51 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/ImageTest.cpp View 1 2 3 4 3 chunks +94 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
bsalomon
The color table variation doesn't work because SkImage::peekPixels(SkPixmap*) doesn't populate the color table of the ...
4 years, 9 months ago (2016-03-09 16:41:44 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1776913003/diff/1/tests/ImageTest.cpp File tests/ImageTest.cpp (right): https://codereview.chromium.org/1776913003/diff/1/tests/ImageTest.cpp#newcode75 tests/ImageTest.cpp:75: } // Add a comment about why this ...
4 years, 9 months ago (2016-03-09 16:51:28 UTC) #5
bsalomon
https://codereview.chromium.org/1776913003/diff/1/tests/ImageTest.cpp File tests/ImageTest.cpp (right): https://codereview.chromium.org/1776913003/diff/1/tests/ImageTest.cpp#newcode75 tests/ImageTest.cpp:75: } On 2016/03/09 16:51:28, robertphillips wrote: > // Add ...
4 years, 9 months ago (2016-03-09 16:55:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776913003/40001
4 years, 9 months ago (2016-03-09 18:35:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/6978) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 9 months ago (2016-03-09 18:40:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776913003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776913003/60001
4 years, 9 months ago (2016-03-09 19:04:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/7020)
4 years, 9 months ago (2016-03-09 19:08:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776913003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776913003/80001
4 years, 9 months ago (2016-03-09 19:20:40 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 19:31:21 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/045afea97902936869d71389e656a9c6917fa32f

Powered by Google App Engine
This is Rietveld 408576698