Do not use setInnerText in INPUT / TEXTAREA

Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of TEXTAREA on setting
value. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix them
soon.

BUG=268807, 593184
R=yosin@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/764e6bb1b05458cde3ca0702ceb801d25c3dcc3b

[tkent, 2016-03-09 08:02:19]

Patchset #2 (id:20001) has been deleted

[tkent, 2016-03-09 08:02:24]

Patchset #1 (id:1) has been deleted

[tkent, 2016-03-09 08:03:39]

Description was changed from

==========
Use setTextContent instead of setInnerText in INPUT / TEXTAREA.

This means we don't produce <br> in shadow editing elements of INPUT and
TEXTAREA. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are alrady broken and we'll fix them
soon.

BUG=268807, 593184
==========

to

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of INPUT and
TEXTAREA. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
==========

[tkent, 2016-03-09 08:20:44]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-03-09 08:20:45]

yosin@, would you review this please?

[tkent, 2016-03-09 08:21:30]

Description was changed from

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of INPUT and
TEXTAREA. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
==========

to

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of TEXTAREA on
setting
value. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
==========

[yosin_UTC9, 2016-03-09 08:33:22]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-03-09 08:33:22]

lgtm

[commit-bot: I haz the power, 2016-03-09 08:33:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776903003/40001

[tkent, 2016-03-09 08:42:04]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-03-10 00:57:02]

https://codereview.chromium.org/1776903003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp (right):

https://codereview.chromium.org/1776903003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp:640: if
(value.isEmpty())
I added this code after yosin's lgtm.  Both of setInnerText and setTextContent
have this logic.

 if (value.isEmpty())
     innerEditor->removeChildren();
 else
     replaceChildrenWithText(...)

[tkent, 2016-03-10 00:57:14]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-03-10 00:57:14]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1776903003/#ps60001
(title: "Fix some test failures")

[commit-bot: I haz the power, 2016-03-10 00:57:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776903003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776903003/60001

[commit-bot: I haz the power, 2016-03-10 02:34:05]

Description was changed from

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of TEXTAREA on
setting
value. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
==========

to

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of TEXTAREA on
setting
value. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
R=yosin@chromium.org

Committed: https://crrev.com/764e6bb1b05458cde3ca0702ceb801d25c3dcc3b
Cr-Commit-Position: refs/heads/master@{#380313}
==========

[commit-bot: I haz the power, 2016-03-10 02:34:06]

Patchset 2 (id:??) landed as
https://crrev.com/764e6bb1b05458cde3ca0702ceb801d25c3dcc3b
Cr-Commit-Position: refs/heads/master@{#380313}

[tkent, 2016-03-10 02:34:44]

Description was changed from

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of TEXTAREA on
setting
value. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
R=yosin@chromium.org

Committed: https://crrev.com/764e6bb1b05458cde3ca0702ceb801d25c3dcc3b
Cr-Commit-Position: refs/heads/master@{#380313}
==========

to

==========
Do not use setInnerText in INPUT / TEXTAREA.

Use replaceChildrenWithText instead.
This means we don't produce <br> in shadow editing elements of TEXTAREA on
setting
value. This change is basically not user-visible except TEXTAREAs with
unusual white-space values.  Such TEXTAREAs are already broken and we'll fix
them
soon.

BUG=268807, 593184
R=yosin@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/764e6bb1b05458cde3ca0702ceb8...
==========

[tkent, 2016-03-10 02:34:47]

Committed patchset #2 (id:60001) manually as
764e6bb1b05458cde3ca0702ceb801d25c3dcc3b (presubmit successful).