Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/android/webapps/webapp_registry.h

Issue 1776903002: Refactor BrowsingDataRemover to mock out WebappRegistry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use PostDelayedTask Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/webapps/webapp_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/webapp_registry.h
diff --git a/chrome/browser/android/webapps/webapp_registry.h b/chrome/browser/android/webapps/webapp_registry.h
index 26357bcd56edc2ad0833aadeb2398228e22a83b4..2d0a2cb9630ebc6c5c6183fae09d49b635271486 100644
--- a/chrome/browser/android/webapps/webapp_registry.h
+++ b/chrome/browser/android/webapps/webapp_registry.h
@@ -12,18 +12,22 @@
// WebappRegistry is the C++ counterpart of
// org.chromium.chrome.browser.webapp's WebappRegistry in Java.
+// All methods in this class which make JNI calls should be declared virtual and
+// mocked out in C++ unit tests. The JNI call cannot be made in this environment
+// as the Java side will not be initialised.
class WebappRegistry {
public:
+ WebappRegistry() { }
+ virtual ~WebappRegistry() { }
+
// Registers JNI hooks.
static bool RegisterWebappRegistry(JNIEnv* env);
// Cleans up data stored by web apps.
- static void UnregisterWebapps(const base::Closure& callback);
+ virtual void UnregisterWebapps(const base::Closure& callback);
private:
- ~WebappRegistry() = delete;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(WebappRegistry);
+ DISALLOW_COPY_AND_ASSIGN(WebappRegistry);
};
#endif // CHROME_BROWSER_ANDROID_WEBAPPS_WEBAPP_REGISTRY_H_
« no previous file with comments | « no previous file | chrome/browser/android/webapps/webapp_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698