Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 17769005: Rewrite scoped_ptr<T>(NULL) to use the default ctor. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Mac... hopefully for real this time. BUG=173286 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_view_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
My original directions omitted the .mm/.m files from being included in the compile DB. Oops.
7 years, 6 months ago (2013-06-25 23:35:31 UTC) #1
Nico
change lgtm On 2013/06/25 23:35:31, dcheng wrote: > My original directions omitted the .mm/.m files ...
7 years, 6 months ago (2013-06-25 23:37:18 UTC) #2
dcheng
On 2013/06/25 23:37:18, Nico wrote: > change lgtm > > On 2013/06/25 23:35:31, dcheng wrote: ...
7 years, 6 months ago (2013-06-25 23:37:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/17769005/1
7 years, 6 months ago (2013-06-25 23:37:50 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-26 00:18:38 UTC) #5
dcheng
7 years, 6 months ago (2013-06-26 02:03:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r208591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698