Clang upload bots: don't run hooks or mb.

Clang upload bots: don't run hooks or mb.

These bots don't need anything like that. It also sames a trouble
of dealing with update.py being called as a part of runhooks,
which would try to download Clang binaries which don't yet exist.

BUG=593154, 578306
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299171

[krasin1, 2016-03-09 03:10:58]

krasin@chromium.org changed reviewers:
+ dpranke@google.com, krasin@chromium.org

[krasin1, 2016-03-09 03:10:58]

Hello Dirk,

this is another take on the Clang Upload problem. I don't call hooks or mb, and
try to manually to download binutils, which are required for building LLVM Gold
plugin.

Please, take a look.

[Nico, 2016-03-09 03:18:04]

(isn't that what i suggested on the src-side change?)

[krasin1, 2016-03-09 03:25:20]

On 2016/03/09 03:18:04, Nico wrote:
> (isn't that what i suggested on the src-side change?)

I think it's exactly what you have suggested. :)

[Dirk Pranke, 2016-03-09 03:26:13]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-09 03:26:14]

okay, I don't know what these scripts do, so I can't really review this, but as
I noted in the other CL, do you not need some equivalent of the 'clang_tot'
script to download tip-of-tree clang? Or is that all handled in the package
script somehow?

However, I can at least ask with some confidence: shouldn't there be
-expected.json changes for the builders from this?

[krasin1, 2016-03-09 03:29:11]

On 2016/03/09 03:26:14, Dirk Pranke wrote:
> okay, I don't know what these scripts do, so I can't really review this, but
as
> I noted in the other CL, do you not need some equivalent of the 'clang_tot'
> script to download tip-of-tree clang? Or is that all handled in the package
> script somehow?
it's all handled by update.py when a local build is requested. No need to
download clang_tot.
In fact clang_tot is not even a part of the equation. It takes a pinned revision
and builds it (twice: with GCC, then with the just build Clang).
Hans, Nico: please, correct, if I am wrong.

> 
> However, I can at least ask with some confidence: shouldn't there be
> -expected.json changes for the builders from this?
Yeah, I forgot to run the training script. For some reason, git cl upload didn't
complain.

Done.

[Nico, 2016-03-09 03:31:56]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-09 03:31:57]

The clang_tot config sets the LLVM_FORCE_HEAD_REVISION env var, which in turn
makes update.py build head instead of a pinned revision.

The clang upload bots are supposed to _build_ clang at a fixed revision (and
then upload it), so yes, I think they shouldn't have the clang_tot config.

[Dirk Pranke, 2016-03-09 03:33:19]

On 2016/03/09 03:29:11, krasin1 wrote:
> On 2016/03/09 03:26:14, Dirk Pranke wrote:
> > okay, I don't know what these scripts do, so I can't really review this, but
> as
> > I noted in the other CL, do you not need some equivalent of the 'clang_tot'
> > script to download tip-of-tree clang? Or is that all handled in the package
> > script somehow?
> it's all handled by update.py when a local build is requested. No need to
> download clang_tot.
> In fact clang_tot is not even a part of the equation. It takes a pinned
revision
> and builds it (twice: with GCC, then with the just build Clang).
> Hans, Nico: please, correct, if I am wrong.

You mean package.py handles everything, right? update.py isn't being called ...

[krasin1, 2016-03-09 03:40:16]

On 2016/03/09 03:33:19, Dirk Pranke wrote:
> On 2016/03/09 03:29:11, krasin1 wrote:
> > On 2016/03/09 03:26:14, Dirk Pranke wrote:
> > > okay, I don't know what these scripts do, so I can't really review this,
but
> > as
> > > I noted in the other CL, do you not need some equivalent of the
'clang_tot'
> > > script to download tip-of-tree clang? Or is that all handled in the
package
> > > script somehow?
> > it's all handled by update.py when a local build is requested. No need to
> > download clang_tot.
> > In fact clang_tot is not even a part of the equation. It takes a pinned
> revision
> > and builds it (twice: with GCC, then with the just build Clang).
> > Hans, Nico: please, correct, if I am wrong.
> 
> You mean package.py handles everything, right? update.py isn't being called
...

That's right. package.py then calls update.py:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/clang/script...

[Nico, 2016-03-09 04:08:16]

package.py mostly calls update.py internally :-)

[Nico, 2016-03-09 04:13:24]

huh, sorry, gmail didn't show krasin's reply for 30 minutes for me. ignore me,
he said that already.

[Dirk Pranke, 2016-03-09 04:23:40]

ok, lgtm.

[krasin1, 2016-03-09 04:27:50]

The CQ bit was checked by krasin@chromium.org

[commit-bot: I haz the power, 2016-03-09 04:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776893002/20001

[commit-bot: I haz the power, 2016-03-09 04:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 04:35:10]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[krasin1, 2016-03-09 04:46:55]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2016-03-09 04:46:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1776893002/#ps40001
(title: "remove unused vars to make presubmit happy")

[commit-bot: I haz the power, 2016-03-09 04:47:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776893002/40001

[commit-bot: I haz the power, 2016-03-09 04:56:59]

Description was changed from

==========
Clang upload bots: don't run hooks or mb.

These bots don't need anything like that. It also sames a trouble
of dealing with update.py being called as a part of runhooks,
which would try to download Clang binaries which don't yet exist.

BUG=593154,578306
==========

to

==========
Clang upload bots: don't run hooks or mb.

These bots don't need anything like that. It also sames a trouble
of dealing with update.py being called as a part of runhooks,
which would try to download Clang binaries which don't yet exist.

BUG=593154,578306

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299171
==========

[commit-bot: I haz the power, 2016-03-09 04:57:01]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299171