Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: pydir/run-pnacl-sz.py

Issue 1776843002: Allow subzero tests to pass without le32-nacl-objdump. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Responses to code review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests_lit/lit.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/run-pnacl-sz.py
diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py
index b11ca60f05c061bf2692c19d8ec2b805b9eeb9c7..c1e4f3ad1c7bc4c81ef9ea9851ecb2ecca29c25e 100755
--- a/pydir/run-pnacl-sz.py
+++ b/pydir/run-pnacl-sz.py
@@ -31,6 +31,9 @@ def TargetDisassemblerFlags(target):
'mips32':[] }
return flags[target]
+def GetObjdumpCmd():
+ """Return a suitable objdump command."""
+ return 'arm-nacl-objdump'
def main():
"""Run the pnacl-sz compiler on an llvm file.
@@ -196,7 +199,7 @@ def main():
cmd += ['-o', output_file_name]
if args.disassemble:
# Show wide instruction encodings, diassemble, and show relocs.
- cmd += (['&&', os.path.join(pnacl_bin_path, 'le32-nacl-objdump')] +
+ cmd += (['&&', os.path.join(pnacl_bin_path, GetObjdumpCmd())] +
args.dis_flags +
['-w', '-d', '-r'] + TargetDisassemblerFlags(args.target) +
[output_file_name])
« no previous file with comments | « no previous file | tests_lit/lit.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698