Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 1776833002: txnbuf: Add write count budget, size budget. (Closed)

Created:
4 years, 9 months ago by dnj
Modified:
4 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

txnbuf: Add write count budget, size budget. Add a "maximum number of datastore writes" budget to the transaction buffer. Rework the size budget to remove preemptive child transaction failures and directly derive budget from the parent. BUG= Committed: https://github.com/luci/gae/commit/1ad17ed9115aa1e9414475e6bd60da943705f02b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -39 lines) Patch
M filter/txnBuf/state.go View 7 chunks +40 lines, -18 lines 0 comments Download
M filter/txnBuf/txnbuf_test.go View 1 chunk +53 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
PTAL
4 years, 9 months ago (2016-03-09 00:57:45 UTC) #2
iannucci
lgtm
4 years, 9 months ago (2016-03-09 01:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776833002/1
4 years, 9 months ago (2016-03-09 01:03:08 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 01:08:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/1ad17ed9115aa1e9414475e6bd60da943705f02b

Powered by Google App Engine
This is Rietveld 408576698