Clip Views textfield drag images to selected text.

Clip Views textfield drag images to selected text.

Paint views::Textfield drag images with views::Labels.
Makes the drag image fit the size of the selected text.
(not as wide as the origin Omnibox/textfield itself)
Use an offset for the image similar to the Unity desktop.

This changes the appearance of split-selection BiDi text.
(doesn't show blank area between the visually split text)
See before/after pictures at http://crbug.com/349105

Remove now unused RenderText::DrawSelectedTextForDrag.

BUG=349105
TEST=Linux Aura and ChromeOS text drag images look good.
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255310

[msw, 2014-03-05 21:56:34]

Hey Scott, please take a look; thanks!

[sky, 2014-03-05 23:28:43]

https://codereview.chromium.org/177683005/diff/100001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/177683005/diff/100001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:851:
label.SetBoundsRect(gfx::Rect(label.GetPreferredSize()));
Should this be capped in anyway? What if the text is really really long?

https://codereview.chromium.org/177683005/diff/100001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:860: static const gfx::Vector2d
kOffset(-15, 0);
nit: no static here.
Also, shouldn't the offset be based on the font size?

[msw, 2014-03-06 00:00:42]

https://codereview.chromium.org/177683005/diff/100001/ui/views/controls/textf...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/177683005/diff/100001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:851:
label.SetBoundsRect(gfx::Rect(label.GetPreferredSize()));
On 2014/03/05 23:28:43, sky wrote:
> Should this be capped in anyway? What if the text is really really long?

Good point! I tried some very long strings and it drew a broken canvas on Linux
Desktop Aura and crashed ChromeOS! I changed this to cap at the display width
(and textfield height) and now the same tests draw the beginning of the string
as you might expect without crashing CrOS. Thoughts?

https://codereview.chromium.org/177683005/diff/100001/ui/views/controls/textf...
ui/views/controls/textfield/textfield.cc:860: static const gfx::Vector2d
kOffset(-15, 0);
On 2014/03/05 23:28:43, sky wrote:
> nit: no static here.
> Also, shouldn't the offset be based on the font size?

Removed static. No, a (0,0) offset here puts the top left of the text drag image
at the cursor point. The 15px X-axis offset places it next to the cursor like
Unity on Goobuntu (so it's not overlapped and obscured by the cursor). The
Y-axis offset value here is ignored and clamped to 0 by
X11WholeScreenMoveLoop::SetDragImage. I think it looks okay, but perhaps we want
to change that in a followup CL?

[sky, 2014-03-06 00:02:35]

Ok, LGTM

[msw, 2014-03-06 00:21:35]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-03-06 00:25:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/177683005/140001

[commit-bot: I haz the power, 2014-03-06 01:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 01:34:38]

Retried try job too often on win for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[msw, 2014-03-06 01:54:41]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-03-06 01:55:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/177683005/140001

[commit-bot: I haz the power, 2014-03-06 02:59:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/177683005/140001

[commit-bot: I haz the power, 2014-03-06 03:20:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/177683005/140001

[commit-bot: I haz the power, 2014-03-06 10:59:44]

Change committed as 255310