LayoutTests/fast/forms/form-submission-cancelable.html - Issue 177683004: Don't delay submit in onsubmit event handler

Side by Side Diff: LayoutTests/fast/forms/form-submission-cancelable.html

Issue 177683004: Don't delay submit in onsubmit event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <form method="GET" action="data:text/html,

	8 <script>

	9 window.onload= function() {

	10 var query=window.location.search;

	11 console.log(query);

	12 console.log(query.indexOf('query=AAA') == 1);
	keishi 2014/02/28 10:57:48 We should use js-test.js shouldBe* methods if poss We should use js-test.js shouldBe* methods if possible to make it clear what is pass/fail. We can probably do something like this (I haven't tested this code myself) <iframe id="target" onload="testSubmission1()"></iframe> <iframe id="target1" onload="testSubmission2()"></iframe> <script> var count = 2; function testSubmission1() { shouldBeEqualToString('event.target.contentWindow.location.search', '?query=AAA'); if (--count === 0) finishJSTest(); } function testSubmission2() { shouldBeEqualToString('event.target.contentWindow.location.search', '?query=BBB'); if (--count === 0) finishJSTest(); } </script> Habib Virji 2014/03/04 14:37:53 Done. Show quoted text On 2014/02/28 10:57:48, keishi1 wrote: > We should use js-test.js shouldBe* methods if possible to make it clear what is > pass/fail. > We can probably do something like this (I haven't tested this code myself) > <iframe id="target" onload="testSubmission1()"></iframe> > <iframe id="target1" onload="testSubmission2()"></iframe> > <script> > var count = 2; > function testSubmission1() { > shouldBeEqualToString('event.target.contentWindow.location.search', > '?query=AAA'); > if (--count === 0) > finishJSTest(); > } > function testSubmission2() { > shouldBeEqualToString('event.target.contentWindow.location.search', > '?query=BBB'); > if (--count === 0) > finishJSTest(); > } > </script> Done.
	13 }

	14 </script>" target="target">

	15 <input name="query" value="AAA" />

	16 <input type="submit" id="submitButton"/>

	17 </form>

	18

	19 <form method="GET" action="data:text/html,

	20 <script>

	21 window.onload= function() {

	22 var query=window.location.search;

	23 console.log(query);

	24 console.log(query.indexOf('query1=BBB') == 1);

	25 window.testRunner && testRunner.notifyDone();

	26 }

	27 </script>" target="target1">

	28 <input name="query1" value="AAA" />

	29 <input type="submit" id="submitButton1"/>

	30 </form>

	31 <script>

	32 description("Test for the form submit, when prevented should not submit the form");
	keishi 2014/02/28 10:57:48 This bug is not about respecting the return value This bug is not about respecting the return value of the event handler. I think the problem is that we have code that delays submits within onsubmit event handlers. I think the description should be like "Test that submit within onsubmit event handlers are not delayed" or "Test that form submit within onsubmit event handlers send the the form data at the time they were called". I think the bug description ("Value set in form submission depends on return value of onSubmit") should be updated to something like "Don't delay submit in onsubmit event handler". keishi 2014/02/28 10:57:48 nit: We should unify string literals to single quo nit: We should unify string literals to single quotes in layout tests. Habib Virji 2014/03/04 14:37:53 Done. Show quoted text On 2014/02/28 10:57:48, keishi1 wrote: > This bug is not about respecting the return value of the event handler. I think > the problem is that we have code that delays submits within onsubmit event > handlers. I think the description should be like "Test that submit within > onsubmit event handlers are not delayed" or "Test that form submit within > onsubmit event handlers send the the form data at the time they were called". > > I think the bug description ("Value set in form submission depends on return > value of onSubmit") should be updated to something like "Don't delay submit in > onsubmit event handler". Done.
	33 if (window.testRunner)

	34 {
	keishi 2014/02/28 10:57:48 nit: No line break before braces in JavaScript. nit: No line break before braces in JavaScript. Habib Virji 2014/03/04 14:37:53 Done. Show quoted text On 2014/02/28 10:57:48, keishi1 wrote: > nit: No line break before braces in JavaScript. Done.
	35 testRunner.dumpAsText();
	keishi 2014/02/28 10:57:48 We have js-test.js so this is already done. We have js-test.js so this is already done. Habib Virji 2014/03/04 14:37:53 Done. Show quoted text On 2014/02/28 10:57:48, keishi1 wrote: > We have js-test.js so this is already done. Done.
	36 testRunner.setCanOpenWindows();
	keishi 2014/02/28 10:57:48 I think we don't need these lines? (setCanOpenWind I think we don't need these lines? (setCanOpenWindows, setPopupBlockingEnabled, setCloseRemainingWindowsWhenComplete) Habib Virji 2014/03/04 14:37:53 Done. Show quoted text On 2014/02/28 10:57:48, keishi1 wrote: > I think we don't need these lines? (setCanOpenWindows, setPopupBlockingEnabled, > setCloseRemainingWindowsWhenComplete) Done.
	37 testRunner.setPopupBlockingEnabled(true);

	38 testRunner.setCloseRemainingWindowsWhenComplete(true);

	39 testRunner.waitUntilDone();
	keishi 2014/02/28 10:57:48 We have js-test.js so we can use window.jsTestIsAs We have js-test.js so we can use window.jsTestIsAsync = true; Habib Virji 2014/03/04 14:37:53 Done. Show quoted text On 2014/02/28 10:57:48, keishi1 wrote: > We have js-test.js so we can use > window.jsTestIsAsync = true; Done.
	40 }

	41

	42 document.forms[0].onsubmit = function (event)

	43 {

	44 document.forms[0].submit();

	45 document.forms[0].children.query.value = 'BBB';

	46 return false;

	47 }

	48

	49 document.forms[1].onsubmit = function (event)

	50 {

	51 document.forms[1].submit();

	52 document.forms[1].children.query1.value = 'BBB';

	53 return true;

	54 }

	55

	56 window.onload = function()

	57 {

	58 document.getElementById('submitButton').click();

	59 document.getElementById('submitButton1').click();

	60 }

	61

	62 </script>

	63

	64 <iframe id="target"></iframe>

	65 <iframe id="target1"></iframe>

	66 </body>

	67 </html>

	68

	69

	70

	71

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/form-submission-cancelable-expected.txt » ('j') | Source/core/html/HTMLFormElement.cpp » ('J')