Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 177683002: Mode clean-up pt 1: rename classic/non-strict mode to sloppy mode (Closed)

Created:
6 years, 10 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Mode clean-up pt 1: rename classic/non-strict mode to sloppy mode R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19799

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -604 lines) Patch
M src/a64/builtins-a64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/a64/code-stubs-a64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/a64/full-codegen-a64.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M src/a64/ic-a64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/accessors.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/builtins-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/array.js View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/builtins.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/builtins.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/code-stubs.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/codegen.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/compilation-cache.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/contexts.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.h View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 9 chunks +19 lines, -19 lines 0 comments Download
M src/elements-kind.h View 1 chunk +1 line, -1 line 0 comments Download
M src/elements-kind.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 2 chunks +4 lines, -7 lines 1 comment Download
M src/harmony-array.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/i18n.cc View 33 chunks +40 lines, -40 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M src/ia32/ic-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ic.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ic.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/isolate.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 11 chunks +36 lines, -37 lines 0 comments Download
M src/messages.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/objects.h View 7 chunks +14 lines, -14 lines 0 comments Download
M src/objects.cc View 34 chunks +37 lines, -37 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 14 chunks +17 lines, -17 lines 0 comments Download
M src/preparser.h View 6 chunks +9 lines, -9 lines 2 comments Download
M src/preparser.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M src/runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 37 chunks +41 lines, -42 lines 0 comments Download
M src/scopeinfo.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scopes.h View 5 chunks +12 lines, -14 lines 0 comments Download
M src/scopes.cc View 10 chunks +22 lines, -23 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M src/variables.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M src/x64/ic-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 12 chunks +25 lines, -25 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 8 chunks +41 lines, -41 lines 0 comments Download
M test/mjsunit/harmony/block-let-declaration.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/generators-parsing.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies-example-membrane.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-function.js View 3 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-2273.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-2564.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/value-wrapper-accessor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 10 months ago (2014-02-24 12:03:16 UTC) #1
Michael Starzinger
LGTM. Whatever floats your boat man. :) https://codereview.chromium.org/177683002/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/177683002/diff/1/src/globals.h#newcode411 src/globals.h:411: // TODO(rossberg): ...
6 years, 10 months ago (2014-02-24 15:09:14 UTC) #2
rossberg
6 years, 9 months ago (2014-03-11 14:39:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19799.

Powered by Google App Engine
This is Rietveld 408576698