Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1776713005: Initialize member variables from all constructors (Closed)

Created:
4 years, 9 months ago by dmazzoni
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang, David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize member variables from all constructors A recent change added last_focused_node_ and last_focused_manager_ to BrowserAccessibilityManager but accidentally didn't initialize them from both constructors. BUG=593907 TBR=dtseng@chromium.org TBR=thestig@chromium.org NOTRY=true Committed: https://crrev.com/0958a444aefc5b2847e46dff8bc6f82fb27ec6f1 Cr-Commit-Position: refs/heads/master@{#380487}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776713005/1
4 years, 9 months ago (2016-03-10 22:31:02 UTC) #4
Lei Zhang
lgtm
4 years, 9 months ago (2016-03-10 23:07:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/129024) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-10 23:08:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776713005/1
4 years, 9 months ago (2016-03-10 23:11:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 23:18:42 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 23:20:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0958a444aefc5b2847e46dff8bc6f82fb27ec6f1
Cr-Commit-Position: refs/heads/master@{#380487}

Powered by Google App Engine
This is Rietveld 408576698