Move CPDF_NumberTree to fpdfdoc.

Move CPDF_NumberTree to fpdfdoc.

It's not used anywhere in fpdfapi, and can become restricted
to fpdfoc/.

R=ochang@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/c7c2115d33c5e6cee5e3d5215e3357b859f5990e

[Tom Sepez, 2016-03-10 00:25:28]

tsepez@chromium.org changed reviewers:
+ ochang@chromium.org

[Tom Sepez, 2016-03-10 00:25:28]

ochang, please review.

[Oliver Chang, 2016-03-10 00:45:45]

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils.cpp
File core/src/fpdfdoc/doc_utils.cpp (right):

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.cpp:19: CPDF_Object*
SearchNumberNode(CPDF_Dictionary* pNode, int num) {
can this be const CPDF_Dictionary* ?

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils.h
File core/src/fpdfdoc/doc_utils.h (right):

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:17: CPDF_NumberTree(CPDF_Dictionary* pRoot) {
m_pRoot = pRoot; }
initialiser list?

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:19: CPDF_Object* LookupValue(int num);
while you're here, can this be made const?

[Tom Sepez, 2016-03-10 00:54:28]

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils.cpp
File core/src/fpdfdoc/doc_utils.cpp (right):

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.cpp:19: CPDF_Object*
SearchNumberNode(CPDF_Dictionary* pNode, int num) {
On 2016/03/10 00:45:45, Oliver Chang wrote:
> can this be const CPDF_Dictionary* ?

Done.

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils.h
File core/src/fpdfdoc/doc_utils.h (right):

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:17: CPDF_NumberTree(CPDF_Dictionary* pRoot) {
m_pRoot = pRoot; }
On 2016/03/10 00:45:45, Oliver Chang wrote:
> initialiser list?

Done.

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:19: CPDF_Object* LookupValue(int num);
On 2016/03/10 00:45:45, Oliver Chang wrote:
> while you're here, can this be made const?

Done.

[Oliver Chang, 2016-03-10 00:55:25]

lgtm

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils.h
File core/src/fpdfdoc/doc_utils.h (right):

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:19: CPDF_Object* LookupValue(int num);
On 2016/03/10 00:54:28, Tom Sepez wrote:
> On 2016/03/10 00:45:45, Oliver Chang wrote:
> > while you're here, can this be made const?
> 
> Done.

Sorry, I meant CPDF_Object* LookupValue(int num) const;

[Tom Sepez, 2016-03-10 00:58:40]

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils.h
File core/src/fpdfdoc/doc_utils.h (right):

https://codereview.chromium.org/1776713004/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:19: CPDF_Object* LookupValue(int num);
On 2016/03/10 00:55:25, Oliver Chang wrote:
> On 2016/03/10 00:54:28, Tom Sepez wrote:
> > On 2016/03/10 00:45:45, Oliver Chang wrote:
> > > while you're here, can this be made const?
> > 
> > Done.
> 
> Sorry, I meant CPDF_Object* LookupValue(int num) const;

Done.

[Tom Sepez, 2016-03-10 01:00:13]

Description was changed from

==========
Move CPDF_NumberTree to fpdfdoc.

It's not used anywhere in fpdfapi, and can become restricted
to fpdfoc/.
==========

to

==========
Move CPDF_NumberTree to fpdfdoc.

It's not used anywhere in fpdfapi, and can become restricted
to fpdfoc/.

R=ochang@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/c7c2115d33c5e6cee5e3d5215e3357b859f5...
==========

[Tom Sepez, 2016-03-10 01:00:14]

Committed patchset #3 (id:40001) manually as
c7c2115d33c5e6cee5e3d5215e3357b859f5990e (presubmit successful).