Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1776683003: Remove destructuring and default arguments runtime flags (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove destructuring and default arguments runtime flags These flags have been on by default since version 4.9, which has been in stable Chrome for over a week now, demonstrating that they're here to stay. Also moved the tests out of harmony/ and into es6/. Committed: https://crrev.com/dea955945761f798518040ae9d555e9d9d888527 Cr-Commit-Position: refs/heads/master@{#34692}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2423 lines) Patch
M src/bootstrapper.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/parsing/parser.cc View 1 10 chunks +4 lines, -26 lines 0 comments Download
M src/parsing/parser-base.h View 1 8 chunks +2 lines, -36 lines 0 comments Download
M src/parsing/preparser.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 31 chunks +48 lines, -134 lines 0 comments Download
M test/message/default-parameter-tdz.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/default-parameter-tdz-arrow.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-array2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-obj.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-decl-no-init-obj2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/destructuring-modify-const.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/for-in-loop-initializers-destructuring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/let-lexical-name-in-array-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/let-lexical-name-in-object-prohibited.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/try-catch-lexical-conflict.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/try-catch-variable-conflict.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/block-let-contextual-sloppy.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/es6/debug-step-destructuring-assignment.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/es6/debug-step-destructuring-bind.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/default-parameters-destructuring.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/destructuring.js View 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/es6/destructuring-assignment.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/destructuring-assignment-lazy.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/destructuring-parameters-literalcount.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/es6/destructuring-parameters-literalcount-nolazy.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/new-target.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/regress/regress-4395.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4395-global-eval.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4585.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-517455.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-cr512574.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/super.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-sloppy-function.js View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/harmony/debug-step-destructuring-assignment.js View 1 chunk +0 lines, -86 lines 0 comments Download
D test/mjsunit/harmony/debug-step-destructuring-bind.js View 1 chunk +0 lines, -110 lines 0 comments Download
D test/mjsunit/harmony/default-parameters-destructuring.js View 1 chunk +0 lines, -112 lines 0 comments Download
D test/mjsunit/harmony/destructuring.js View 1 chunk +0 lines, -1137 lines 0 comments Download
D test/mjsunit/harmony/destructuring-assignment.js View 1 chunk +0 lines, -482 lines 0 comments Download
D test/mjsunit/harmony/destructuring-assignment-lazy.js View 1 chunk +0 lines, -15 lines 0 comments Download
D test/mjsunit/harmony/destructuring-parameters-literalcount.js View 1 chunk +0 lines, -41 lines 0 comments Download
D test/mjsunit/harmony/destructuring-parameters-literalcount-nolazy.js View 1 chunk +0 lines, -41 lines 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/harmony/function-name.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/harmony/regress/regress-4395.js View 1 chunk +0 lines, -104 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4395-global-eval.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-4585.js View 1 chunk +0 lines, -16 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-517455.js View 1 chunk +0 lines, -8 lines 0 comments Download
M test/mjsunit/regress/regress-552302.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-572589.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/class-syntax-declaration.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/class-syntax-expression.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
adamk
4 years, 9 months ago (2016-03-09 00:18:36 UTC) #2
rossberg
lgtm
4 years, 9 months ago (2016-03-10 10:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776683003/20001
4 years, 9 months ago (2016-03-10 22:47:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 23:19:37 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 23:22:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dea955945761f798518040ae9d555e9d9d888527
Cr-Commit-Position: refs/heads/master@{#34692}

Powered by Google App Engine
This is Rietveld 408576698