Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: ui/events/event.cc

Issue 1776673007: [Windows] Produce correct DomKey for NumPad when combined with Shift/NumLock (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wez's review Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/event.cc
diff --git a/ui/events/event.cc b/ui/events/event.cc
index ca6704b6f8fa5b6e49888074b799c620b7bc90e2..106c3a9ab02ba488a06875cce32a1d31b9cdf29e 100644
--- a/ui/events/event.cc
+++ b/ui/events/event.cc
@@ -865,7 +865,7 @@ KeyEvent::KeyEvent(const base::NativeEvent& native_event)
if (is_char_)
key_ = DomKey::FromCharacter(native_event.wParam);
else
- key_ = PlatformKeyMap::DomCodeAndFlagsToDomKeyStatic(code_, flags());
+ key_ = PlatformKeyMap::DomKeyFromNativeStatic(native_event);
Wez 2016/03/18 22:50:39 nit: It'd be more in-keeping w/ Chromium style tha
chongz 2016/03/21 20:07:28 Done.
#endif
}

Powered by Google App Engine
This is Rietveld 408576698