Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1776673006: rewrite_to_chrome_style: Add some additional macro test cases. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
Reviewers:
dcheng
CC:
dcheng, chromium-reviews, piman, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Add some additional macro test cases. R=dcheng BUG=584094 Committed: https://crrev.com/6ac498bf759b48c43fa69eadbc16048650a2ae6b Cr-Commit-Position: refs/heads/master@{#380265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M tools/clang/rewrite_to_chrome_style/tests/macros-expected.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/macros-original.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danakj
4 years, 9 months ago (2016-03-09 22:16:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776673006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776673006/1
4 years, 9 months ago (2016-03-09 22:16:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-09 22:16:47 UTC) #5
dcheng
lgtm
4 years, 9 months ago (2016-03-09 22:18:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776673006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776673006/1
4 years, 9 months ago (2016-03-09 22:19:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 00:04:02 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 00:06:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ac498bf759b48c43fa69eadbc16048650a2ae6b
Cr-Commit-Position: refs/heads/master@{#380265}

Powered by Google App Engine
This is Rietveld 408576698