base: Add blame context

base/test/trace_event_analyzer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use trace_analyzer::Query and trace_analyzer::TraceAnalyzer to search for
 // specific trace events that were generated by the trace_event.h API.
 //
 // Basic procedure:
 // - Get trace events JSON string from base::trace_event::TraceLog.
 // - Create TraceAnalyzer with JSON string.
@@ skipping 102 matching lines @@
   TraceEvent();
   TraceEvent(const TraceEvent& other);
   ~TraceEvent();
 
   bool SetFromJSON(const base::Value* event_value) WARN_UNUSED_RESULT;
 
   bool operator< (const TraceEvent& rhs) const {
     return timestamp < rhs.timestamp;
   }
 
+  void operator=(const TraceEvent& rhs);

[danakj, 2016/03/16 18:29:49]

TraceEvent is pretty heavy. Does it need to be copyable? Can it be moveable
instead?

Anyhow, in this case a move would be far cheaper than a copy (this thing is full
of stl containers), so if you're going to add a copy operator i recomment a move
one too (and a move constructor).

[Sami, 2016/03/17 12:27:13]

It's kept around in stl containers so it needs to be copyable at minimum. A move
operator & constructor sounds like a good idea -- done.

[danakj, 2016/03/18 21:22:22]

STL containers don't need to copy anymore with C++11.

+
   bool has_other_event() const { return other_event; }
 
   // Returns absolute duration in microseconds between this event and other
   // event. Must have already verified that other_event exists by
   // Query(EVENT_HAS_OTHER) or by calling has_other_event().
   double GetAbsTimeToOtherEvent() const;
 
   // Return the argument value if it exists and it is a string.
   bool GetArgAsString(const std::string& name, std::string* arg) const;
   // Return the argument value if it exists and it is a number.
   bool GetArgAsNumber(const std::string& name, double* arg) const;
+  // Return the argument value if it exists.
+  bool GetArgAsValue(const std::string& name,
+                     scoped_ptr<base::Value>* arg) const;
 
   // Check if argument exists and is string.
   bool HasStringArg(const std::string& name) const;
   // Check if argument exists and is number (double, int or bool).
   bool HasNumberArg(const std::string& name) const;
+  // Check if argument exists.
+  bool HasArg(const std::string& name) const;
 
   // Get known existing arguments as specific types.
   // Useful when you have already queried the argument with
   // Query(HAS_NUMBER_ARG) or Query(HAS_STRING_ARG).
   std::string GetKnownArgAsString(const std::string& name) const;
   double GetKnownArgAsDouble(const std::string& name) const;
   int GetKnownArgAsInt(const std::string& name) const;
   bool GetKnownArgAsBool(const std::string& name) const;
+  scoped_ptr<base::Value> GetKnownArgAsValue(const std::string& name) const;
 
   // Process ID and Thread ID.
   ProcessThreadID thread;
 
   // Time since epoch in microseconds.
   // Stored as double to match its JSON representation.
   double timestamp;
 
   double duration;
 
   char phase;
 
   std::string category;
 
   std::string name;
 
   std::string id;
 
   // All numbers and bool values from TraceEvent args are cast to double.
   // bool becomes 1.0 (true) or 0.0 (false).
   std::map<std::string, double> arg_numbers;
 
   std::map<std::string, std::string> arg_strings;
 
+  std::map<std::string, scoped_ptr<base::Value>> arg_values;
+

[danakj, 2016/03/16 18:29:49]

The

amount

of

whitespace

in

this

class

is

impressive :)

[Sami, 2016/03/17 12:27:13]

Now that you mention it I think I'll just compact it :)

   // The other event associated with this event (or NULL).
   const TraceEvent* other_event;
 };
 
 typedef std::vector<const TraceEvent*> TraceEventVector;
 
 class Query {
  public:
   Query(const Query& query);
 
@@ skipping 521 matching lines @@
 
 // Count all matches.
 static inline size_t CountMatches(const TraceEventVector& events,
                                   const Query& query) {
   return CountMatches(events, query, 0u, events.size());
 }
 
 }  // namespace trace_analyzer
 
 #endif  // BASE_TEST_TRACE_EVENT_ANALYZER_H_