Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1776663002: Revert of Update V8 to version 5.1.71. (Closed)

Created:
4 years, 9 months ago by anthonyvd
Modified:
4 years, 9 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.1.71. (patchset #1 id:1 of https://codereview.chromium.org/1772343002/ ) Reason for revert: This appears to be causing this failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8923 Original issue's description: > Update V8 to version 5.1.71. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/609ae417..70e72db4 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/a210fc29470a85435f76a1af9e6990249f063a38 > Cr-Commit-Position: refs/heads/master@{#379816} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bbb3fe5e44bd211fb9959ceb8d5bfcfbb4d9c72b Cr-Commit-Position: refs/heads/master@{#379825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
anthonyvd
Created Revert of Update V8 to version 5.1.71.
4 years, 9 months ago (2016-03-08 14:57:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776663002/1
4 years, 9 months ago (2016-03-08 14:57:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 14:57:41 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bbb3fe5e44bd211fb9959ceb8d5bfcfbb4d9c72b Cr-Commit-Position: refs/heads/master@{#379825}
4 years, 9 months ago (2016-03-08 14:59:17 UTC) #5
Michael Achenbach
4 years, 9 months ago (2016-03-08 15:03:51 UTC) #6
Message was sent while issue was closed.
lgtm - though, I was under the impression that the chromium CQ has 100% compile
coverage for all tree closers - apparently that's not the case. Maybe somebody
should add msan compile to the CQ.

Powered by Google App Engine
This is Rietveld 408576698