Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1776613002: [wasm] Int64Lowering of I64XConvertI32. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Int64Lowering of I64XConvertI32. R=titzer@chromium.org Committed: https://crrev.com/d7ddd35c297b7fa4e054d67d6ffbe096f806f439 Cr-Commit-Position: refs/heads/master@{#34629}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -10 lines) Patch
M src/compiler/int64-lowering.cc View 1 1 chunk +25 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 9 months ago (2016-03-08 13:37:10 UTC) #1
titzer
On 2016/03/08 13:37:10, ahaas wrote: lgtm
4 years, 9 months ago (2016-03-09 13:59:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776613002/20001
4 years, 9 months ago (2016-03-09 16:00:09 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 16:21:04 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 16:21:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d7ddd35c297b7fa4e054d67d6ffbe096f806f439
Cr-Commit-Position: refs/heads/master@{#34629}

Powered by Google App Engine
This is Rietveld 408576698