Issue 177653008: Fully unreference run_gpu_test and delete it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 177653008: Fully unreference run_gpu_test and delete it. (Closed)

Created:
6 years, 10 months ago by Ken Russell (switch to Gerrit)

Modified:
6 years, 10 months ago

Reviewers:
Zhenyao Mo, Yaron, Sami

CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, piman+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fully unreference run_gpu_test and delete it. Second try. TBR'ing because the CQ won't catch failures in this area anyway; I'll watch the bots as this lands. BUG=346585 TBR=zmo@chromium.org,skyostil@chromium.org,yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253070

Patch Set 1 #

Patch Set 2 : Retry failed upload. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	D	content/test/gpu/run_gpu_test	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

FYI. TBR'ing because the CQ wouldn't catch errors in this area anyway. I'll watch the ...

6 years, 10 months ago (2014-02-25 03:30:23 UTC) #1

Ken Russell (switch to Gerrit)

Committed patchset #2 manually as r253070 (presubmit successful).

6 years, 10 months ago (2014-02-25 03:31:16 UTC) #2

Message was sent while issue was closed.

lgtm, thanks for the cleanup.

Expand Messages | Collapse Messages