Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1996)

Unified Diff: Source/devtools/front_end/inspector.js

Issue 177653004: DevTools: Get rid of redundant default selection during inspectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ElementsPanel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/inspector.js
diff --git a/Source/devtools/front_end/inspector.js b/Source/devtools/front_end/inspector.js
index 5b02f3da6bb52c57e44ad405eac521ef3b270bd3..21cbd54389d63a946344e2978a68e8651efb716f 100644
--- a/Source/devtools/front_end/inspector.js
+++ b/Source/devtools/front_end/inspector.js
@@ -773,12 +773,16 @@ WebInspector.inspect = function(payload, hints)
if (object.subtype === "node") {
function callback(nodeId)
{
+ var elementsPanel = /** @type {!WebInspector.ElementsPanel} */ WebInspector.panel("elements");
+ elementsPanel.stopOmittingDefaultSelection();
WebInspector._updateFocusedNode(nodeId);
InspectorFrontendHost.inspectElementCompleted();
object.release();
}
object.pushNodeToFrontend(callback);
- WebInspector.showPanel("elements");
+ var elementsPanel = /** @type {!WebInspector.ElementsPanel} */ WebInspector.panel("elements");
+ elementsPanel.omitDefaultSelection();
+ WebInspector.inspectorView.setCurrentPanel(elementsPanel);
return;
}
@@ -836,7 +840,7 @@ WebInspector._updateFocusedNode = function(nodeId)
InspectorFrontendHost.bringToFront();
WebInspector.inspectElementModeController.disable();
}
- WebInspector.showPanel("elements").revealAndSelectNode(nodeId);
+ WebInspector.panel("elements").revealAndSelectNode(nodeId);
pfeldman 2014/02/25 16:28:12 Do this using revealer instead.
}
WebInspector.evaluateInConsole = function(expression, showResultOnly)
« no previous file with comments | « Source/devtools/front_end/ElementsPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698