Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: Source/devtools/front_end/ScreencastView.js

Issue 177653004: DevTools: Get rid of redundant default selection during inspectElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/devtools/front_end/ElementsPanel.js ('k') | Source/devtools/front_end/inspector.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 * @param {number} nodeId 276 * @param {number} nodeId
277 * @this {WebInspector.ScreencastView} 277 * @this {WebInspector.ScreencastView}
278 */ 278 */
279 function callback(error, nodeId) 279 function callback(error, nodeId)
280 { 280 {
281 if (error) 281 if (error)
282 return; 282 return;
283 if (event.type === "mousemove") 283 if (event.type === "mousemove")
284 this.highlightDOMNode(nodeId, this._inspectModeConfig); 284 this.highlightDOMNode(nodeId, this._inspectModeConfig);
285 else if (event.type === "click") 285 else if (event.type === "click")
286 WebInspector.domAgent.dispatchEventToListeners(WebInspector.DOMA gent.Events.InspectNodeRequested, nodeId); 286 WebInspector.Revealer.reveal(WebInspector.domAgent.nodeForId(nod eId));
287 } 287 }
288 }, 288 },
289 289
290 /** 290 /**
291 * @param {!KeyboardEvent} event 291 * @param {!KeyboardEvent} event
292 */ 292 */
293 _handleKeyEvent: function(event) 293 _handleKeyEvent: function(event)
294 { 294 {
295 if (this._isGlassPaneActive()) { 295 if (this._isGlassPaneActive()) {
296 event.consume(); 296 event.consume();
(...skipping 691 matching lines...) Expand 10 before | Expand all | Expand 10 after
988 * @return {!Element} 988 * @return {!Element}
989 */ 989 */
990 statusBarItem: function() 990 statusBarItem: function()
991 { 991 {
992 if (this._initialized) 992 if (this._initialized)
993 return this._toggleScreencastButton.element; 993 return this._toggleScreencastButton.element;
994 this._statusBarPlaceholder = document.createElement("div"); 994 this._statusBarPlaceholder = document.createElement("div");
995 return this._statusBarPlaceholder; 995 return this._statusBarPlaceholder;
996 } 996 }
997 }; 997 };
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ElementsPanel.js ('k') | Source/devtools/front_end/inspector.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698