Account for scroll origin in scroll animators.

Account for scroll origin in scroll animators.

Blink and cc have different notions of scroll offset - Blink's is relative to
the scroll origin which is non-zero in RTL documents.

The CompositorScrollOffsetAnimationCurve must work entirely in cc scroll offsets
since it is handed over to cc which doesn't know about the scroll origin.

This patch teaches ScrollAnimator and ProgrammaticScrollAnimator to convert in
both directions when creating and using the curve object.

BUG=581264
Committed: https://crrev.com/0bb16600006793953292ee1e7fd8bf0a66f575dc
Cr-Commit-Position: refs/heads/master@{#379974}

[skobes, 2016-03-08 01:26:23]

skobes@chromium.org changed reviewers:
+ szager@chromium.org

[szager1, 2016-03-08 01:53:29]

lgtm with nit

https://codereview.chromium.org/1776503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl-expected.txt
(right):

https://codereview.chromium.org/1776503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl-expected.txt:1:
This test verifies some shit.
Rephrase this :)

[skobes, 2016-03-08 02:05:50]

https://codereview.chromium.org/1776503002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl-expected.txt
(right):

https://codereview.chromium.org/1776503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl-expected.txt:1:
This test verifies some shit.
On 2016/03/08 01:53:29, szager1 wrote:
> Rephrase this :)

whoops, done

[skobes, 2016-03-08 19:12:15]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-03-08 19:12:16]

The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org
Link to the patchset: https://codereview.chromium.org/1776503002/#ps40001
(title: "skip test on Mac")

[commit-bot: I haz the power, 2016-03-08 19:12:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776503002/40001

[commit-bot: I haz the power, 2016-03-08 19:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 19:16:24]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[skobes, 2016-03-08 19:32:18]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-03-08 19:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org
Link to the patchset: https://codereview.chromium.org/1776503002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-08 19:32:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776503002/60001

[skobes, 2016-03-08 19:37:47]

skobes@chromium.org changed reviewers:
+ jbroman@chromium.org

[skobes, 2016-03-08 19:37:47]

+jbroman for Source/platform/OWNERS

[commit-bot: I haz the power, 2016-03-08 19:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 19:43:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbroman, 2016-03-08 20:06:09]

lgtm

https://codereview.chromium.org/1776503002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html
(right):

https://codereview.chromium.org/1776503002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html:20:
if (!window.eventSender || !window.internals) {
super-nit: do you need to check window.internals? (you don't seem to use it)

[skobes, 2016-03-08 20:13:32]

https://codereview.chromium.org/1776503002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html
(right):

https://codereview.chromium.org/1776503002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html:20:
if (!window.eventSender || !window.internals) {
On 2016/03/08 20:06:09, jbroman wrote:
> super-nit: do you need to check window.internals? (you don't seem to use it)

Done.

[skobes, 2016-03-08 20:13:37]

The CQ bit was checked by skobes@chromium.org

[skobes, 2016-03-08 20:13:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbroman@chromium.org, szager@chromium.org
Link to the patchset: https://codereview.chromium.org/1776503002/#ps80001
(title: "super-nit")

[commit-bot: I haz the power, 2016-03-08 20:14:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776503002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776503002/80001

[commit-bot: I haz the power, 2016-03-08 23:51:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-08 23:54:17]

Description was changed from

==========
Account for scroll origin in scroll animators.

Blink and cc have different notions of scroll offset - Blink's is relative to
the scroll origin which is non-zero in RTL documents.

The CompositorScrollOffsetAnimationCurve must work entirely in cc scroll offsets
since it is handed over to cc which doesn't know about the scroll origin.

This patch teaches ScrollAnimator and ProgrammaticScrollAnimator to convert in
both directions when creating and using the curve object.

BUG=581264
==========

to

==========
Account for scroll origin in scroll animators.

Blink and cc have different notions of scroll offset - Blink's is relative to
the scroll origin which is non-zero in RTL documents.

The CompositorScrollOffsetAnimationCurve must work entirely in cc scroll offsets
since it is handed over to cc which doesn't know about the scroll origin.

This patch teaches ScrollAnimator and ProgrammaticScrollAnimator to convert in
both directions when creating and using the curve object.

BUG=581264

Committed: https://crrev.com/0bb16600006793953292ee1e7fd8bf0a66f575dc
Cr-Commit-Position: refs/heads/master@{#379974}
==========

[commit-bot: I haz the power, 2016-03-08 23:54:19]

Patchset 5 (id:??) landed as
https://crrev.com/0bb16600006793953292ee1e7fd8bf0a66f575dc
Cr-Commit-Position: refs/heads/master@{#379974}