Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/intersection-observer/timestamp.html

Issue 1776493002: IntersectionObserver: use an idle callback to send notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: syntax error Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html ('k') | third_party/WebKit/Source/core/dom/IdleRequestCallback.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <script src="../resources/js-test.js"></script> 2 <script src="../resources/js-test.js"></script>
3 <script src="helper-functions.js"></script> 3 <script src="helper-functions.js"></script>
4 <div id="beforeFrame" style="width:100%; height:700px;"></div> 4 <div id="beforeFrame" style="width:100%; height:700px;"></div>
5 <div id="afterFrame" style="width:100%; height:700px;"></div> 5 <div id="afterFrame" style="width:100%; height:700px;"></div>
6 6
7 <script> 7 <script>
8 description("Test that intersection observer time is relative to time in the cal lback context."); 8 description("Test that intersection observer time is relative to time in the cal lback context.");
9 var topWindowEntries = []; 9 var topWindowEntries = [];
10 var iframeWindowEntries = []; 10 var iframeWindowEntries = [];
11 var topWindowObserver;
12 var iframeWindowObserver;
11 var targetIframe; 13 var targetIframe;
12 var iframeScroller; 14 var iframeScroller;
13 var topWindowTime; 15 var topWindowTime;
14 var iframeWindowTime; 16 var iframeWindowTime;
15 var timestampTolerance = 24; // 1.5 times frame duration. 17 var timestampTolerance = 24; // 1.5 times frame duration.
16 18
17 function step0() { 19 function step0() {
18 setTimeout(function() { 20 // Test results are only significant if there's a sufficient gap between
19 // Test results are only significant if there's a sufficient gap between 21 // top window time and iframe window time.
20 // top window time and iframe window time. 22 topWindowTime = performance.now();
21 topWindowTime = performance.now(); 23 iframeWindowTime = targetIframe.contentWindow.performance.now();
22 iframeWindowTime = targetIframe.contentWindow.performance.now(); 24 shouldBeGreaterThan("topWindowTime - iframeWindowTime", "2 * timestampToleranc e");
23 shouldBeGreaterThan("topWindowTime - iframeWindowTime", "2 * timestampTolera nce");
24 25
25 shouldBeEqualToNumber("topWindowEntries.length", 0); 26 topWindowEntries = topWindowEntries.concat(topWindowObserver.takeRecords());
26 shouldBeEqualToNumber("iframeWindowEntries.length", 0); 27 iframeWindowEntries = iframeWindowEntries.concat(iframeWindowObserver.takeReco rds());
27 document.scrollingElement.scrollTop = 200; 28 shouldBeEqualToNumber("topWindowEntries.length", 0);
28 iframeScroller.scrollTop = 250; 29 shouldBeEqualToNumber("iframeWindowEntries.length", 0);
29 requestAnimationFrame(step1); 30 document.scrollingElement.scrollTop = 200;
30 }); 31 iframeScroller.scrollTop = 250;
32 requestAnimationFrame(step1);
31 } 33 }
32 34
33 function step1() { 35 function step1() {
34 setTimeout(function() { 36 topWindowEntries = topWindowEntries.concat(topWindowObserver.takeRecords());
35 topWindowTime = performance.now(); 37 iframeWindowEntries = iframeWindowEntries.concat(iframeWindowObserver.takeReco rds());
36 iframeWindowTime = targetIframe.contentWindow.performance.now(); 38 topWindowTime = performance.now();
37 shouldBeEqualToNumber("topWindowEntries.length", 1); 39 iframeWindowTime = targetIframe.contentWindow.performance.now();
38 if (topWindowEntries.length) { 40 shouldBeEqualToNumber("topWindowEntries.length", 1);
39 shouldBeCloseTo("topWindowEntries[0].time", "topWindowTime", timestampTole rance); 41 if (topWindowEntries.length) {
40 } 42 shouldBeCloseTo("topWindowEntries[0].time", "topWindowTime", timestampTolera nce);
41 shouldBeEqualToNumber("iframeWindowEntries.length", 1); 43 }
42 if (iframeWindowEntries.length) { 44 shouldBeEqualToNumber("iframeWindowEntries.length", 1);
43 shouldBeCloseTo("iframeWindowEntries[0].time", "iframeWindowTime", timesta mpTolerance); 45 if (iframeWindowEntries.length) {
44 } 46 shouldBeCloseTo("iframeWindowEntries[0].time", "iframeWindowTime", timestamp Tolerance);
45 finishJSTest(); 47 }
46 document.scrollingElement.scrollTop = 0; 48 finishJSTest();
47 }); 49 document.scrollingElement.scrollTop = 0;
48 } 50 }
49 51
50 function runTest() { 52 function runTest() {
51 var target = targetIframe.contentDocument.getElementById("target"); 53 var target = targetIframe.contentDocument.getElementById("target");
52 iframeScroller = targetIframe.contentDocument.scrollingElement; 54 iframeScroller = targetIframe.contentDocument.scrollingElement;
53 55
54 // Observer created here, callback created in iframe context. Timestamps shou ld be 56 // Observer created here, callback created in iframe context. Timestamps shou ld be
55 // from this window. 57 // from this window.
56 var observer = new IntersectionObserver(targetIframe.contentDocument.createObs erverCallback(topWindowEntries), {}); 58 topWindowObserver = new IntersectionObserver(targetIframe.contentDocument.crea teObserverCallback(topWindowEntries), {});
57 observer.observe(target); 59 topWindowObserver.observe(target);
58 60
59 // Callback created here, observer created in iframe. Timestamps should be 61 // Callback created here, observer created in iframe. Timestamps should be
60 // from iframe window. 62 // from iframe window.
61 observer = targetIframe.contentDocument.createObserver(function(newEntries) { 63 iframeWindowObserver = targetIframe.contentDocument.createObserver(function(ne wEntries) {
62 for (var i = 0; i < newEntries.length; i++) 64 for (var i = 0; i < newEntries.length; i++)
63 iframeWindowEntries.push(newEntries[i]); 65 iframeWindowEntries.push(newEntries[i]);
64 }); 66 });
65 observer.observe(target); 67 iframeWindowObserver.observe(target);
66 68
67 step0(); 69 // See README for explanation of double RAF.
70 requestAnimationFrame(() => { requestAnimationFrame(step0) });
68 } 71 }
69 72
70 window.onload = function() { 73 window.onload = function() {
71 setTimeout(function() { 74 setTimeout(function() {
72 targetIframe = document.createElement("iframe"); 75 targetIframe = document.createElement("iframe");
73 targetIframe.src = "../resources/intersection-observer-timestamp-subframe.ht ml"; 76 targetIframe.src = "../resources/intersection-observer-timestamp-subframe.ht ml";
74 targetIframe.style = "height: 100px; overflow-y: scroll"; 77 targetIframe.style = "height: 100px; overflow-y: scroll";
75 var afterFrame = document.getElementById("afterFrame"); 78 var afterFrame = document.getElementById("afterFrame");
76 afterFrame.parentNode.insertBefore(targetIframe, afterFrame); 79 afterFrame.parentNode.insertBefore(targetIframe, afterFrame);
77 targetIframe.onload = runTest; 80 targetIframe.onload = runTest;
78 }, 100); 81 }, 100);
79 }; 82 };
80 83
81 </script> 84 </script>
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html ('k') | third_party/WebKit/Source/core/dom/IdleRequestCallback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698