third_party/WebKit/LayoutTests/intersection-observer/observer-without-js-reference.html - Issue 1776493002: IntersectionObserver: use an idle callback to send notifications.

Side by Side Diff: third_party/WebKit/LayoutTests/intersection-observer/observer-without-js-reference.html

Issue 1776493002: IntersectionObserver: use an idle callback to send notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/intersection-observer/iframe-cross-origin.html ('K') | « third_party/WebKit/LayoutTests/intersection-observer/multiple-thresholds-expected.txt ('k') | third_party/WebKit/LayoutTests/intersection-observer/root-margin.html » ('j') | third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/js-test.js"></script>	2 <script src="../resources/js-test.js"></script>

3 <script src="../resources/gc.js"></script>	3 <script src="../resources/gc.js"></script>

4 <div style="width:100%; height:700px;"></div>	4 <div style="width:100%; height:700px;"></div>

5 <div id="target" style="background-color: green; width:100px; height:100px"></di v>	5 <div id="target" style="background-color: green; width:100px; height:100px"></di v>

6 <div style="width:100%; height:700px;"></div>	6 <div style="width:100%; height:700px;"></div>

7	7

8 <script>	8 <script>

9 jsTestIsAsync = true;	9 jsTestIsAsync = true;

10 description("IntersectionObserver continues to produce notifications when it h as no javascript references.");	10 description("IntersectionObserver continues to produce notifications when it has no javascript references.");

11 var target = document.getElementById("target");	11 var target = document.getElementById("target");

12 var entries = [];	12 var entries = [];

13 new IntersectionObserver(function(changes) {	13 new IntersectionObserver(function(changes) {

14 entries.push(...changes);	14 entries.push(...changes);

15 }).observe(target);	15 }).observe(target);

16 gc();	16 gc();

17 document.scrollingElement.scrollTop = 300;	17 document.scrollingElement.scrollTop = 300;

18 requestAnimationFrame(function () {	18 requestAnimationFrame(() => { requestAnimationFrame(() => {

19 setTimeout(function() {	19 setTimeout(() => {

20 shouldBeEqualToNumber("entries.length", 1);	20 shouldBeEqualToNumber("entries.length", 1);

21 finishJSTest();	21 finishJSTest();

22 });	22 }, 100);
	Sami 2016/03/08 17:32:42 Is there a chance this could add some flake? Is there a chance this could add some flake? szager1 2016/03/08 18:51:32 In other tests, I added a call to observer.takeRec Show quoted text On 2016/03/08 17:32:42, Sami wrote: > Is there a chance this could add some flake? In other tests, I added a call to observer.takeRecords() to ensure that the test wasn't missing any pending notifications. This test is meant to cover the case where there are no remaining js references to the observer, so it can't use takeRecords in this way. However, the IO spec guarantees that notifications will be delivered within 100ms, so this tests conformance to that spec. Sami 2016/03/09 18:29:55 I see, that makes sense. Maybe also add correspond Show quoted text On 2016/03/08 18:51:32, szager1 wrote: > On 2016/03/08 17:32:42, Sami wrote: > > Is there a chance this could add some flake? > > In other tests, I added a call to observer.takeRecords() to ensure that the test > wasn't missing any pending notifications. This test is meant to cover the case > where there are no remaining js references to the observer, so it can't use > takeRecords in this way. > > However, the IO spec guarantees that notifications will be delivered within > 100ms, so this tests conformance to that spec. I see, that makes sense. Maybe also add corresponding comment here? szager1 2016/03/09 20:45:25 Done. Show quoted text On 2016/03/09 18:29:55, Sami wrote: > On 2016/03/08 18:51:32, szager1 wrote: > > On 2016/03/08 17:32:42, Sami wrote: > > > Is there a chance this could add some flake? > > > > In other tests, I added a call to observer.takeRecords() to ensure that the > test > > wasn't missing any pending notifications. This test is meant to cover the > case > > where there are no remaining js references to the observer, so it can't use > > takeRecords in this way. > > > > However, the IO spec guarantees that notifications will be delivered within > > 100ms, so this tests conformance to that spec. > > I see, that makes sense. Maybe also add corresponding comment here? Done.
23 });	23 }) });

24 </script>	24 </script>

OLD	NEW