Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: src/IceGlobalInits.cpp

Issue 1776473007: Subzero. Allocate global initializers from a dedicated arena. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: fixes ther llvm2ice converter; fixes the VariableDeclarationList destructor. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceGlobalInits.cpp
diff --git a/src/IceGlobalInits.cpp b/src/IceGlobalInits.cpp
index f46400f7fbf354e7479ebdbc539a24c1cd5d2fc8..d2f9285a97343b6a1719eb0adca402a7304f3c5a 100644
--- a/src/IceGlobalInits.cpp
+++ b/src/IceGlobalInits.cpp
@@ -138,12 +138,12 @@ void FunctionDeclaration::dump(Ostream &Stream) const {
void VariableDeclaration::dumpType(Ostream &Stream) const {
if (!Ice::BuildDefs::dump())
return;
- if (Initializers->size() == 1) {
- Initializers->front()->dumpType(Stream);
+ if (Initializers.size() == 1) {
+ Initializers.front()->dumpType(Stream);
} else {
Stream << "<{ ";
bool IsFirst = true;
- for (const std::unique_ptr<Initializer> &Init : *Initializers) {
+ for (const auto *Init : Initializers) {
if (IsFirst) {
IsFirst = false;
} else {
@@ -163,13 +163,13 @@ void VariableDeclaration::dump(Ostream &Stream) const {
Stream << " " << (IsConstant ? "constant" : "global") << " ";
// Add initializer.
- if (Initializers->size() == 1) {
- Initializers->front()->dump(Stream);
+ if (Initializers.size() == 1) {
+ Initializers.front()->dump(Stream);
} else {
dumpType(Stream);
Stream << " <{ ";
bool IsFirst = true;
- for (const std::unique_ptr<Initializer> &Init : *Initializers) {
+ for (const auto *Init : Initializers) {
if (IsFirst) {
IsFirst = false;
} else {
@@ -199,7 +199,8 @@ void VariableDeclaration::DataInitializer::dump(Ostream &Stream) const {
Stream << " c\"";
// Code taken from PrintEscapedString() in AsmWriter.cpp. Keep the strings in
// the same format as the .ll file for practical diffing.
- for (uint8_t C : Contents) {
+ for (SizeT i = 0; i < ContentsSize; ++i) {
+ uint8_t C = Contents[i];
if (isprint(C) && C != '\\' && C != '"')
Stream << C;
else
« src/IceDefs.h ('K') | « src/IceGlobalInits.h ('k') | src/IceTargetLowering.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698